s3: test conditional put_object() and delete_object()#663
Merged
AliMasarweh merged 9 commits intoceph:masterfrom Jul 28, 2025
Merged
s3: test conditional put_object() and delete_object()#663AliMasarweh merged 9 commits intoceph:masterfrom
AliMasarweh merged 9 commits intoceph:masterfrom
Conversation
280eca2 to
1557dac
Compare
14 tasks
1557dac to
36907dd
Compare
680bca0 to
01b946d
Compare
11b7f71 to
017a7a7
Compare
cbodley
commented
Jul 15, 2025
c231158 to
b24f167
Compare
AliMasarweh
reviewed
Jul 16, 2025
cbodley
commented
Jul 16, 2025
Contributor
Author
cbodley
left a comment
There was a problem hiding this comment.
ack on delete changes from 404->204 👍
f74d07c to
7b7e4a5
Compare
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
7ed5d02 to
6ba7bd5
Compare
we expected an error if we delete non-existent objects but that is not true Signed-off-by: Ali Masarwa <ali.saed.masarwa@gmail.com>
6ba7bd5 to
6833430
Compare
Signed-off-by: Ali Masarwa <ali.saed.masarwa@gmail.com>
AliMasarweh
approved these changes
Jul 28, 2025
Contributor
Author
|
pushed to ceph-master as well |
This was referenced Oct 20, 2025
Contributor
Author
|
cherry-picked to ceph-tentacle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test coverage for ceph/ceph#63348
<ETag><LastModifiedTime><Size>put_object tests are duplicated to test non-versioned and overwrites of a current version
delete_object(s) tests are duplicated to test non-versioned, deletes of a current version, and deletes of a specific version