Skip to content

squid: qa: Add multifs root_squash testcase#65802

Closed
joscollin wants to merge 3 commits intoceph:squidfrom
joscollin:wip-64939-squid
Closed

squid: qa: Add multifs root_squash testcase#65802
joscollin wants to merge 3 commits intoceph:squidfrom
joscollin:wip-64939-squid

Conversation

@joscollin
Copy link
Member

@joscollin joscollin commented Oct 6, 2025

backport tracker: https://tracker.ceph.com/issues/64939


backport of #55833
parent tracker: https://tracker.ceph.com/issues/64641


backport tracker: https://tracker.ceph.com/issues/65907

backport of #56846
parent tracker: https://tracker.ceph.com/issues/65246

Both the trackers need to be backported as the #55833 has a bug.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

kotreshhr and others added 3 commits October 7, 2025 04:23
Fixes: https://tracker.ceph.com/issues/64641
Signed-off-by: Kotresh HR <khiremat@redhat.com>
(cherry picked from commit 1fda8ed)

Conflicts:
  qa/tasks/cephfs/test_admin.py - Few of the other tests got added
in between.
Root squash is valid for kclient too, Kotresh ran test recently fo it
against main branch. Therefore it is safe to remove.
ceph#56846 (comment)

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 422d98c)
test_multifs_single_path_rootsquash was never run with vstart_runner.py
or with teuthology and is therefore full of bugs. Fix it to make sure it
runs fine.

Introduced-by: 1fda8ed
Fixes: https://tracker.ceph.com/issues/65246
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit d9752a6)
@joscollin
Copy link
Member Author

This PR is under test in https://tracker.ceph.com/issues/73450.

self.assertTrue(self.mount_a.is_blocked())


def test_multifs_single_path_rootsquash(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test failed in QA -

2025-10-10T21:21:46.080 INFO:tasks.cephfs_test_runner:======================================================================
2025-10-10T21:21:46.080 INFO:tasks.cephfs_test_runner:ERROR: test_multifs_single_path_rootsquash (tasks.cephfs.test_admin.TestFsAuthorize)
2025-10-10T21:21:46.080 INFO:tasks.cephfs_test_runner:Test root_squash with multi fs
2025-10-10T21:21:46.080 INFO:tasks.cephfs_test_runner:----------------------------------------------------------------------
2025-10-10T21:21:46.081 INFO:tasks.cephfs_test_runner:Traceback (most recent call last):
2025-10-10T21:21:46.081 INFO:tasks.cephfs_test_runner:  File "/home/teuthworker/src/github.com_ceph_ceph-c_104ea276496eeef39137386037044178d6f67f79/qa/tasks/cephfs/test_admin.py", line 1985, in tearDown
2025-10-10T21:21:46.081 INFO:tasks.cephfs_test_runner:    self.mount_a.umount_wait()
2025-10-10T21:21:46.081 INFO:tasks.cephfs_test_runner:  File "/home/teuthworker/src/github.com_ceph_ceph-c_104ea276496eeef39137386037044178d6f67f79/qa/tasks/cephfs/kernel_mount.py", line 191, in umount_wait
2025-10-10T21:21:46.081 INFO:tasks.cephfs_test_runner:    self.umount(force)
2025-10-10T21:21:46.081 INFO:tasks.cephfs_test_runner:  File "/home/teuthworker/src/github.com_ceph_ceph-c_104ea276496eeef39137386037044178d6f67f79/qa/tasks/cephfs/kernel_mount.py", line 170, in umount
2025-10-10T21:21:46.081 INFO:tasks.cephfs_test_runner:    raise e
2025-10-10T21:21:46.081 INFO:tasks.cephfs_test_runner:  File "/home/teuthworker/src/github.com_ceph_ceph-c_104ea276496eeef39137386037044178d6f67f79/qa/tasks/cephfs/kernel_mount.py", line 163, in umount
2025-10-10T21:21:46.081 INFO:tasks.cephfs_test_runner:    self.client_remote.run(args=cmd, timeout=UMOUNT_TIMEOUT, omit_sudo=False)
2025-10-10T21:21:46.081 INFO:tasks.cephfs_test_runner:  File "/home/teuthworker/src/git.ceph.com_teuthology_78c036dc9ad59cb33807dc7f21fda50de2f348d2/teuthology/orchestra/remote.py", line 575, in run
2025-10-10T21:21:46.081 INFO:tasks.cephfs_test_runner:    r = self._runner(client=self.ssh, name=self.shortname, **kwargs)
2025-10-10T21:21:46.081 INFO:tasks.cephfs_test_runner:  File "/home/teuthworker/src/git.ceph.com_teuthology_78c036dc9ad59cb33807dc7f21fda50de2f348d2/teuthology/orchestra/run.py", line 461, in run
2025-10-10T21:21:46.081 INFO:tasks.cephfs_test_runner:    r.wait()
2025-10-10T21:21:46.081 INFO:tasks.cephfs_test_runner:  File "/home/teuthworker/src/git.ceph.com_teuthology_78c036dc9ad59cb33807dc7f21fda50de2f348d2/teuthology/orchestra/run.py", line 161, in wait
2025-10-10T21:21:46.081 INFO:tasks.cephfs_test_runner:    self._raise_for_status()
2025-10-10T21:21:46.082 INFO:tasks.cephfs_test_runner:  File "/home/teuthworker/src/git.ceph.com_teuthology_78c036dc9ad59cb33807dc7f21fda50de2f348d2/teuthology/orchestra/run.py", line 181, in _raise_for_status
2025-10-10T21:21:46.082 INFO:tasks.cephfs_test_runner:    raise CommandFailedError(
2025-10-10T21:21:46.082 INFO:tasks.cephfs_test_runner:teuthology.exceptions.CommandFailedError: Command failed on smithi071 with status 32: 'sudo umount /home/ubuntu/cephtest/mnt.0'

See: https://pulpito.ceph.com/jcollin-2025-10-10_05:57:09-fs:functional-wip-jcollin-testing-20251010.002614-squid-distro-default-smithi/8545208

Copy link
Member Author

@joscollin joscollin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joscollin
Copy link
Member Author

@joscollin
Copy link
Member Author

@joscollin joscollin closed this Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cephfs Ceph File System tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants