qa/cephfs: fix and improve test_multifs_single_path_rootsquash#56846
qa/cephfs: fix and improve test_multifs_single_path_rootsquash#56846rishabh-d-dave merged 2 commits intoceph:mainfrom
Conversation
8baa08b to
a252f54
Compare
|
@kotreshhr I've fixed this test which was written by you. I am not fully aware of the context of why this test added (the PR that added it has only this test and no other changes to source code). So please take a look and let me know if this looks like the test case you had in mind. Locally it is running fine now. If you find it okay, we can proceed for full QA run. |
vshankar
left a comment
There was a problem hiding this comment.
Thx for fixing this @rishabh-d-dave - not sure how this change wasn't picked up in my test branch. I have now started to push my tag so that the branch name shows up in the PR.
I left a small comment. Otherwise LGTM.
rishabh-d-dave
left a comment
There was a problem hiding this comment.
QA run was successful - https://tracker.ceph.com/projects/cephfs/wiki/Main#26-APR-2024
* refs/pull/56846/head: qa/cephfs: fix test_multifs_single_path_rootsquash qa/cephfs: improvement for test_multifs_single_path_rootsquash Reviewed-by: Xiubo Li <xiubli@redhat.com>
Root squash is valid for kclient too, Kotresh ran test recently fo it against main branch. Therefore it is safe to remove. ceph#56846 (comment) Signed-off-by: Rishabh Dave <ridave@redhat.com>
test_multifs_single_path_rootsquash was never run with vstart_runner.py or with teuthology and is therefore full of bugs. Fix it to make sure it runs fine. Introduced-by: 1fda8ed Fixes: https://tracker.ceph.com/issues/65246 Signed-off-by: Rishabh Dave <ridave@redhat.com>
a252f54 to
d9752a6
Compare
There was a problem hiding this comment.
QA run was successful - https://tracker.ceph.com/projects/cephfs/wiki/main#3-May-2024.
Testing took more time than expected because there were 25-30 new failures. Most of them caused by a PR in the testing branch but these were resolved on removing that PR.
EDIT Had a chat with Venky about this PR, since QA is fine and current change is very minor, it's okay to merge it.
|
Ceph API test failure looks like the transient failure we were seeing last to last week roughly - https://jenkins.ceph.com/job/ceph-api/73423/. Relauncing it since it's need in order to merge this PR. |
|
jenkins test api |
1 similar comment
|
jenkins test api |
|
jenkins test api |
|
Leaving link here to QA results again - #56846 (review) |
Root squash is valid for kclient too, Kotresh ran test recently fo it against main branch. Therefore it is safe to remove. ceph#56846 (comment) Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 422d98c)
Root squash is valid for kclient too, Kotresh ran test recently fo it against main branch. Therefore it is safe to remove. ceph#56846 (comment) Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 422d98c)
Root squash is valid for kclient too, Kotresh ran test recently fo it against main branch. Therefore it is safe to remove. ceph/ceph#56846 (comment) Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 422d98c)
Root squash is valid for kclient too, Kotresh ran test recently fo it against main branch. Therefore it is safe to remove. ceph#56846 (comment) Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 422d98c)
Root squash is valid for kclient too, Kotresh ran test recently fo it against main branch. Therefore it is safe to remove. ceph#56846 (comment) Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 422d98c)
Introduced-by: 1fda8ed, #55833
Fixes: https://tracker.ceph.com/issues/65246
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e