Skip to content

cephfs_mirror: deprecate peer_add command#65309

Merged
joscollin merged 2 commits intoceph:mainfrom
joscollin:wip-72683-peer-add-deprecate
Sep 26, 2025
Merged

cephfs_mirror: deprecate peer_add command#65309
joscollin merged 2 commits intoceph:mainfrom
joscollin:wip-72683-peer-add-deprecate

Conversation

@joscollin
Copy link
Member

@joscollin joscollin commented Aug 29, 2025 •
edited
Loading

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@joscollin joscollin requested a review from a team as a code owner August 29, 2025 12:10
@github-actions
Copy link

github-actions bot commented Aug 29, 2025

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@joscollin joscollin force-pushed the wip-72683-peer-add-deprecate branch from 294bd0e to 04347f0 Compare August 29, 2025 12:11
@joscollin joscollin force-pushed the wip-72683-peer-add-deprecate branch from 04347f0 to ca01649 Compare August 29, 2025 12:14
anthonyeleven
anthonyeleven reviewed Aug 29, 2025
View reviewed changes
@joscollin joscollin marked this pull request as draft September 1, 2025 06:02
@joscollin joscollin force-pushed the wip-72683-peer-add-deprecate branch from ca01649 to de822f0 Compare September 1, 2025 08:17
@joscollin joscollin marked this pull request as ready for review September 1, 2025 08:17
@joscollin
Copy link
Member Author

joscollin commented Sep 2, 2025

jenkins test make check

@joscollin
Copy link
Member Author

joscollin commented Sep 2, 2025

jenkins test make check arm64

@joscollin joscollin requested a review from vshankar September 2, 2025 07:21
@joscollin joscollin force-pushed the wip-72683-peer-add-deprecate branch from de822f0 to 9f100d5 Compare September 5, 2025 10:33
@joscollin
Copy link
Member Author

joscollin commented Sep 9, 2025

@vshankar ping

vshankar
vshankar reviewed Sep 9, 2025
View reviewed changes
vshankar
vshankar reviewed Sep 9, 2025
View reviewed changes
@joscollin joscollin force-pushed the wip-72683-peer-add-deprecate branch 2 times, most recently from cf45300 to e2b221e Compare September 9, 2025 04:15
anthonyeleven
anthonyeleven reviewed Sep 9, 2025
View reviewed changes
@joscollin joscollin force-pushed the wip-72683-peer-add-deprecate branch from e2b221e to ecee575 Compare September 10, 2025 03:44
@joscollin
Copy link
Member Author

joscollin commented Sep 10, 2025

jenkins test make check

@joscollin
Copy link
Member Author

joscollin commented Sep 10, 2025

jenkins test make check arm64

@vshankar
Copy link
Contributor

vshankar commented Sep 10, 2025

jenkins test make check

@vshankar
Copy link
Contributor

vshankar commented Sep 10, 2025

jenkins test make check arm64

@anthonyeleven
Copy link
Contributor

anthonyeleven commented Sep 16, 2025

Please take out the quotes in the PR title. I’ve seen those cause problems in the past.

@joscollin joscollin changed the title cephfs_mirror: deprecate 'peer_add' command cephfs_mirror: deprecate peer_add command Sep 17, 2025
@joscollin
cephfs_mirror: deprecate 'peer_add' command
611dce0 
Fixes: https://tracker.ceph.com/issues/72683
Signed-off-by: Jos Collin <jcollin@redhat.com>
@joscollin
doc: deprecate 'peer_add' command
d19d3f5 
Fixes: https://tracker.ceph.com/issues/72683
Signed-off-by: Jos Collin <jcollin@redhat.com>
@joscollin joscollin force-pushed the wip-72683-peer-add-deprecate branch from ecee575 to d19d3f5 Compare September 17, 2025 06:49
@vshankar
Copy link
Contributor

vshankar commented Sep 17, 2025

This PR is under test in https://tracker.ceph.com/issues/73082.

@joscollin
Copy link
Member Author

joscollin commented Sep 17, 2025

@vshankar

Test Passed:
https://pulpito.ceph.com/jcollin-2025-09-17_11:15:30-fs:mirror-wip-jcollin-testing_17092025_2-distro-default-smithi/

vshankar added a commit to vshankar/ceph that referenced this pull request Sep 26, 2025
@vshankar
Merge PR ceph#65309 into wip-vshankar-testing-20250926.051223
ca19b0f 
* refs/pull/65309/head:

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
@vshankar
Copy link
Contributor

vshankar commented Sep 26, 2025

This is good to merge 👍

@joscollin joscollin merged commit 4c9887d into ceph:main Sep 26, 2025
13 checks passed
@joscollin joscollin deleted the wip-72683-peer-add-deprecate branch September 26, 2025 14:53
@github-actions
Copy link

github-actions bot commented Sep 26, 2025

This is an automated message by src/script/redmine-upkeep.py.

I have resolved the following tracker ticket due to the merge of this PR:

No backports are pending for the ticket. If this is incorrect, please update the tracker
ticket and reset to Pending Backport state.

Update Log: https://github.com/ceph/ceph/actions/runs/18041298095

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

@anthonyeleven anthonyeleven anthonyeleven approved these changes

Assignees

No one assigned

Labels

cephfs Ceph File System documentation pybind wip-kdhaduk-testing wip-vshankar-testing2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joscollin @vshankar @anthonyeleven @kdhaduk81