Skip to content

cephfs.pyx: handle when UID/GID passed to chown() is -1#64999

Merged
rishabh-d-dave merged 2 commits intoceph:mainfrom
rishabh-d-dave:fs-pyx-chown
Sep 9, 2025
Merged

cephfs.pyx: handle when UID/GID passed to chown() is -1#64999
rishabh-d-dave merged 2 commits intoceph:mainfrom
rishabh-d-dave:fs-pyx-chown

Conversation

@rishabh-d-dave
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave commented Aug 12, 2025 •
edited
Loading

When chown() in libcephfs call receives -1 as the value of UID/GID, it
is implicitly converted from signed integer to unsigned integeer but
CephFS cython instead of doing that errors out during complilation.
Therefore make this conversion explicitly to allow users to pass -1
(which they do to indicate that UID/GID value shouldn't be changed) and
also for sake of uniformity and consistency between between CephFS
cython and libcephfs interface.

Fixes: https://tracker.ceph.com/issues/72547
Introduced-by: 65328ac, PR #62934.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@rishabh-d-dave rishabh-d-dave requested a review from a team August 12, 2025 17:11
@github-actions github-actions bot added the tests label Aug 12, 2025
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Aug 12, 2025

.

batrick
batrick approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Please add a comment to the conversion noting this works around:

OverflowError: can't convert negative value to gid_t .

@rishabh-d-dave
cephfs.pyx: handle when UID/GID passed to chown() is -1
325ae11 
When chown() in libcephfs call receives -1 as the value of UID/GID, it
is implicitly converted from signed integer to unsigned integeer but
CephFS cython instead of doing that errors out during complilation.
Therefore make this conversion explicitly to allow users to pass -1
(which they do to indicate that UID/GID value shouldn't be changed) and
also for sake of uniformity and consistency between between CephFS
cython and libcephfs interface.

Fixes: https://tracker.ceph.com/issues/72547
Introduced-by: 65328ac
Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Aug 13, 2025

Good work. Please add a comment to the conversion noting this works around:

OverflowError: can't convert negative value to gid_t .

Done.

vshankar
vshankar reviewed Aug 13, 2025
View reviewed changes
@rishabh-d-dave
test/pybind/cephfs.pyx: add tests for chown()
069bede 
Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Aug 13, 2025

fs:libcephfs ran succesfully - https://pulpito.ceph.com/rishabh-2025-08-13_10:14:02-fs:libcephfs-rishabh-fs-pyx-chown-2-testing-default-smithi/

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Aug 13, 2025

fs:libcephfs passed - https://pulpito.ceph.com/rishabh-2025-08-13_10:14:02-fs:libcephfs-rishabh-fs-pyx-chown-2-testing-default-smithi/

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Aug 13, 2025

jenkins test make check

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Aug 13, 2025

jenkins test make check arm64

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Aug 14, 2025

jenkins test make check

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Aug 14, 2025

jenkins test make check arm64

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Aug 15, 2025

jenkins test make check

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Aug 15, 2025

jenkins test make check arm64

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Aug 19, 2025

jenkins test make check arm64

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Aug 19, 2025

jenkins test make check

@vshankar
Copy link
Contributor

vshankar commented Aug 21, 2025

This PR is under test in https://tracker.ceph.com/issues/72684.

vshankar
vshankar approved these changes Sep 1, 2025
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tracker.ceph.com/projects/cephfs/wiki/QA_main_2025#wip-vshankar-testing-20250825134853-debug

@vshankar
Copy link
Contributor

vshankar commented Sep 1, 2025

jenkins retest this please

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Sep 8, 2025

jenkins test make check arm64

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Sep 8, 2025

jenkins test api

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Sep 9, 2025 •
edited
Loading

@vshankar CI is green, can we merge this PR?

@rishabh-d-dave rishabh-d-dave merged commit 9c7cda9 into ceph:main Sep 9, 2025
13 checks passed
@rishabh-d-dave rishabh-d-dave deleted the fs-pyx-chown branch September 9, 2025 03:55
rishabh-d-dave added a commit to rishabh-d-dave/ceph that referenced this pull request Oct 16, 2025
@rishabh-d-dave
qa, test: run unit tests for cephfs.pyx with non-root user
7666ced 
Run test_python.sh with non-root user. This makes it necessary to change
the owner user and group of file system root to be same as this non-root
user. This brings testing closer to the real-world scenario and also
allows exercising negative tests where an FS op would fail for a non-root
user but it would pass for root user.

There are few tests that exercise FS operations where root user is
needed. Group these tests under a separate class and add extra code for
this class that allows these tests to run with root UID and GID.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 6021dda)

Conflicts:
src/test/pybind/test_cephfs.py
- PR ceph#64999 is merged in main but not in Squid, causing this branch to
  have less tests that need to be moved to class TestWithRootUser.
rishabh-d-dave added a commit to rishabh-d-dave/ceph that referenced this pull request Oct 16, 2025
@rishabh-d-dave
qa, test: run unit tests for cephfs.pyx with non-root user
184455a 
Run test_python.sh with non-root user. This makes it necessary to change
the owner user and group of file system root to be same as this non-root
user. This brings testing closer to the real-world scenario and also
allows exercising negative tests where an FS op would fail for a non-root
user but it would pass for root user.

There are few tests that exercise FS operations where root user is
needed. Group these tests under a separate class and add extra code for
this class that allows these tests to run with root UID and GID.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 6021dda)

Conflicts:
src/test/pybind/test_cephfs.py
- PR ceph#64999 is merged in main but not in Reef (bug is absent in Reef),
  causing this file to have less tests that need to be moved to class
  TestWithRootUser.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

@batrick batrick batrick approved these changes

Assignees

No one assigned

Labels

cephfs Ceph File System needs-review pybind tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rishabh-d-dave @vshankar @batrick