libcephfs / pybind: use uid_t and gid_t instead of int#62934
Merged
libcephfs / pybind: use uid_t and gid_t instead of int#62934
Conversation
allows for setting uid/gid over 2^31-1 through libcephfs Fixes: https://tracker.ceph.com/issues/71015 Signed-off-by: Cecilia Lau <cecilialau6776@gmail.com>
Collaborator
|
Can one of the admins verify this patch? |
Contributor
|
The other APIs in |
dparmar18
approved these changes
Apr 24, 2025
vshankar
approved these changes
May 7, 2025
Contributor
|
jenkins test api |
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/71260. |
Contributor
|
jenkins test api |
Contributor
Suite run looks good. This will be merged soon. |
Contributor
|
jenkins test api |
vshankar
approved these changes
May 20, 2025
Contributor
|
jenkins retest this please |
Contributor
|
jenkins test api |
anoopcs9
added a commit
to anoopcs9/ceph
that referenced
this pull request
Jun 4, 2025
We recently had ABI changes[1] with respect to APIs from chown() family which calls for a change in major version. Native users of the library may not have to change their code but expected sizes differ when data type for parameters are changed. However go-ceph, Go bindings for ceph, couldn't build unless the ABI change is made visible to the consumers of the API. Following the Semantic Versioning guidelines[2] we reset minor and patch (extra) versions to 0. [1] ceph#62934 [2] https://semver.org/#spec-item-8 Fixes: https://tracker.ceph.com/issues/71519 Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
anoopcs9
added a commit
to anoopcs9/ceph
that referenced
this pull request
Jun 4, 2025
We recently had ABI changes[1] with respect to APIs from chown() family which calls for a change in major version. Native users of the library may not have to change their code but expected sizes differ when data type for parameters are changed. However go-ceph, Go bindings for ceph, couldn't build[2] unless the ABI change is made visible to the consumers of the API. Following the Semantic Versioning guidelines[3] we reset minor and patch (extra) versions to 0. [1] ceph#62934 [2] ceph/go-ceph#1119 [3] https://semver.org/#spec-item-8 Fixes: https://tracker.ceph.com/issues/71519 Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
aainscow
pushed a commit
to aainscow/ceph
that referenced
this pull request
Jun 10, 2025
We recently had ABI changes[1] with respect to APIs from chown() family which calls for a change in major version. Native users of the library may not have to change their code but expected sizes differ when data type for parameters are changed. However go-ceph, Go bindings for ceph, couldn't build[2] unless the ABI change is made visible to the consumers of the API. Following the Semantic Versioning guidelines[3] we reset minor and patch (extra) versions to 0. [1] ceph#62934 [2] ceph/go-ceph#1119 [3] https://semver.org/#spec-item-8 Fixes: https://tracker.ceph.com/issues/71519 Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
samarahu
pushed a commit
to samarahu/ceph
that referenced
this pull request
Jun 25, 2025
We recently had ABI changes[1] with respect to APIs from chown() family which calls for a change in major version. Native users of the library may not have to change their code but expected sizes differ when data type for parameters are changed. However go-ceph, Go bindings for ceph, couldn't build[2] unless the ABI change is made visible to the consumers of the API. Following the Semantic Versioning guidelines[3] we reset minor and patch (extra) versions to 0. [1] ceph#62934 [2] ceph/go-ceph#1119 [3] https://semver.org/#spec-item-8 Fixes: https://tracker.ceph.com/issues/71519 Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allows for setting
uid/gidover 2^31-1 throughlibcephfsandpybind/libcephfsFixes: https://tracker.ceph.com/issues/71015
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition