Merged
Conversation
Fixes: https://tracker.ceph.com/issues/72167 Signed-off-by: Kotresh HR <khiremat@redhat.com>
The multifs auth caps bug has a fix both in client and mds. If it's old client and not patched, we expect that the fs with 'rw' would end up having 'r' caps with the multifs auth caps used as in the test 'test_multifs_single_client_cross_access_r_caps_end'. This patch adds the conditional to validate the same. This commit makes use of the PR ceph#64005 Fixes: https://tracker.ceph.com/issues/72167 Signed-off-by: Kotresh HR <khiremat@redhat.com>
The fsname is not take into consideration while validating the access check for the operations. This patch fixes the same. Fixes: https://tracker.ceph.com/issues/72167 Signed-off-by: Kotresh HR <khiremat@redhat.com>
The fsname needs to be passed to validate the mds auth caps check. This patch fixes the same. Fixes: https://tracker.ceph.com/issues/72167 Signed-off-by: Kotresh HR <khiremat@redhat.com>
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
jenkins test make check arm64 |
Contributor
Author
|
jenkins test make check |
Fix the TestMDSAuthCaps after fixing multifs authcaps comparison. Fixes: https://tracker.ceph.com/issues/72167 Signed-off-by: Kotresh HR <khiremat@redhat.com>
Contributor
Author
|
jenkins test make check arm64 |
batrick
approved these changes
Jul 28, 2025
vshankar
approved these changes
Aug 4, 2025
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/72416. |
vshankar
added a commit
to vshankar/ceph
that referenced
this pull request
Aug 12, 2025
* refs/pull/64550/head: Reviewed-by: Patrick Donnelly <pdonnell@ibm.com> Reviewed-by: Venky Shankar <vshankar@redhat.com>
vshankar
reviewed
Aug 13, 2025
The kclient fix isn't yet landed in the kernel and hence the test 'test_multifs_single_client_cross_access_r_caps_end' would fail for kernel mount. So disable the failing validation in the test for kclient. Fixes: https://tracker.ceph.com/issues/72167 Signed-off-by: Kotresh HR <khiremat@redhat.com>
Contributor
Author
|
jenkins test make check |
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/72684. |
vshankar
approved these changes
Sep 1, 2025
This was referenced Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fsname is not take into consideration while validating
the access check for the operations. This patch fixes
the same.
Fixes: https://tracker.ceph.com/issues/72167
Signed-off-by: Kotresh HR khiremat@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition