Skip to content

qa: Run test_admin with the older client#64005

Merged
vshankar merged 1 commit intoceph:mainfrom
kotreshhr:qa-testing-specific-client-version
Jul 21, 2025
Merged

qa: Run test_admin with the older client#64005
vshankar merged 1 commit intoceph:mainfrom
kotreshhr:qa-testing-specific-client-version

Conversation

@kotreshhr
Copy link
Contributor

@kotreshhr kotreshhr commented Jun 18, 2025 •
edited
Loading

qa: Run test_admin with the squid client

This is required to test the features involving
fixes both in client and mds. This is to make
sure the older clients are not broken with the
fix. The version 19.2.2 is used for client.

The test suite sets up the cluster with squid
19.2.2 and upgrades mds and other daemons except
the client.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@github-actions github-actions bot added cephfs Ceph File System tests labels Jun 18, 2025
@kotreshhr kotreshhr force-pushed the qa-testing-specific-client-version branch 3 times, most recently from 53d574b to 7f11f7f Compare June 19, 2025 12:03
@dparmar18
Copy link
Contributor

dparmar18 commented Jun 19, 2025

@kotreshhr are you going to make use of staggered upgrade for this?

@kotreshhr kotreshhr force-pushed the qa-testing-specific-client-version branch 4 times, most recently from 2e025d6 to d8a1563 Compare June 23, 2025 10:48
@kotreshhr
Copy link
Contributor Author

kotreshhr commented Jun 23, 2025

Sample test runs on main -
https://pulpito.ceph.com/khiremat-2025-06-23_10:58:34-fs:bugs-main-distro-default-smithi/
https://pulpito.ceph.com/khiremat-2025-06-23_11:05:11-fs:bugs-main-distro-default-smithi/

@kotreshhr kotreshhr marked this pull request as ready for review June 23, 2025 17:16
@kotreshhr
Copy link
Contributor Author

kotreshhr commented Jun 23, 2025

jenkins test make check

@kotreshhr
Copy link
Contributor Author

kotreshhr commented Jun 23, 2025

jenkins test windows

@kotreshhr
Copy link
Contributor Author

kotreshhr commented Jun 23, 2025

jenkins test make check arm64

@kotreshhr
Copy link
Contributor Author

kotreshhr commented Jun 24, 2025

jenkins test make check

@kotreshhr
Copy link
Contributor Author

kotreshhr commented Jun 24, 2025

@kotreshhr are you going to make use of staggered upgrade for this?

Yes

@kotreshhr kotreshhr requested review from a team, dparmar18 and vshankar June 24, 2025 03:27
@dparmar18
Copy link
Contributor

dparmar18 commented Jun 24, 2025 •
edited
Loading

from https://pulpito.ceph.com/khiremat-2025-06-23_10:58:34-fs:bugs-main-distro-default-smithi/8341901:

before upgrade:

2025-06-23T11:14:34.920 DEBUG:teuthology.orchestra.run.smithi125:> rpm -q ceph --qf '%{VERSION}-%{RELEASE}'
2025-06-23T11:14:34.947 INFO:teuthology.orchestra.run.smithi125.stdout:19.2.2-0.el9
2025-06-23T11:14:34.947 INFO:teuthology.packaging:The installed version of ceph is 19.2.2-0.el9
2025-06-23T11:14:34.947 INFO:teuthology.task.install:The correct ceph version 19.2.2-0 is installed.

after upgrade:

2025-06-23T11:17:13.550 DEBUG:teuthology.orchestra.run.smithi022:> rpm -q ceph --qf '%{VERSION}-%{RELEASE}'
2025-06-23T11:17:13.575 INFO:teuthology.orchestra.run.smithi022.stdout:20.3.0-974.gdf5c005d.el9
2025-06-23T11:17:13.575 INFO:teuthology.packaging:The installed version of ceph is 20.3.0-974.gdf5c005d.el9
2025-06-23T11:17:13.575 INFO:teuthology.task.install:The correct ceph version 20.3.0-974.gdf5c005d is installed.
2025-06-23T11:17:13.577 INFO:teuthology.run_tasks:Running task print...
2025-06-23T11:17:13.588 INFO:teuthology.task.print:**** done install.upgrade the host

LGTM

batrick
batrick requested changes Jul 2, 2025
View reviewed changes
kotreshhr added a commit to kotreshhr/ceph that referenced this pull request Jul 8, 2025
@kotreshhr
qa: Fix cephfs_client_version
c3d7c62 
The multifs auth caps bug has a fix both in client and mds.
If it's old client and not patched, we expect that the fs
with 'rw' would end up having 'r' caps with the multifs
auth caps used as in the test
'test_multifs_single_client_cross_access_r_caps_end'.
This patch adds the conditional to validate the same.

This commit makes use of the PR ceph#64005

Signed-off-by: Kotresh HR <khiremat@redhat.com>
@kotreshhr
qa: Run test_admin with the squid client
a4f97c0 
This is required to test the features involving
fixes both in client and mds. This is to make
sure the older clients are not broken with the
fix. The version 19.2.2 is used for client.

The test suite sets up the cluster with squid
19.2.2 and upgrades only the ceph cluster node
leaving the client node.

Signed-off-by: Kotresh HR <khiremat@redhat.com>
@kotreshhr kotreshhr force-pushed the qa-testing-specific-client-version branch from d8a1563 to a4f97c0 Compare July 8, 2025 11:07
@kotreshhr
Copy link
Contributor Author

kotreshhr commented Jul 8, 2025

https://pulpito.ceph.com/khiremat-2025-07-08_11:11:38-fs:bugs-main-distro-default-smithi/

@kotreshhr
Copy link
Contributor Author

kotreshhr commented Jul 9, 2025

jenkins test make check arm64

@vshankar
Copy link
Contributor

vshankar commented Jul 10, 2025

This PR is under test in https://tracker.ceph.com/issues/72073.

kotreshhr added a commit to kotreshhr/ceph that referenced this pull request Jul 17, 2025
@kotreshhr
qa: Fix validation of client_version
f10e34d 
The multifs auth caps bug has a fix both in client and mds.
If it's old client and not patched, we expect that the fs
with 'rw' would end up having 'r' caps with the multifs
auth caps used as in the test
'test_multifs_single_client_cross_access_r_caps_end'.
This patch adds the conditional to validate the same.

This commit makes use of the PR ceph#64005

Fixes: https://tracker.ceph.com/issues/72167
Signed-off-by: Kotresh HR <khiremat@redhat.com>
vshankar
vshankar approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tracker.ceph.com/projects/cephfs/wiki/QA_main_2025#wip-vshankar-testing-20250714111344-debug

@vshankar vshankar merged commit 044f718 into ceph:main Jul 21, 2025
13 checks passed
This was referenced Aug 27, 2025
Closed
Open
Closed
joscollin pushed a commit to joscollin/ceph that referenced this pull request Sep 3, 2025
@kotreshhr @joscollin
qa: Fix validation of client_version
25d85f1 
The multifs auth caps bug has a fix both in client and mds.
If it's old client and not patched, we expect that the fs
with 'rw' would end up having 'r' caps with the multifs
auth caps used as in the test
'test_multifs_single_client_cross_access_r_caps_end'.
This patch adds the conditional to validate the same.

This commit makes use of the PR ceph#64005

Fixes: https://tracker.ceph.com/issues/72167
Signed-off-by: Kotresh HR <khiremat@redhat.com>
(cherry picked from commit f10e34d)
kotreshhr added a commit to kotreshhr/ceph that referenced this pull request Sep 3, 2025
@kotreshhr
qa: Fix validation of client_version
66fd5fd 
The multifs auth caps bug has a fix both in client and mds.
If it's old client and not patched, we expect that the fs
with 'rw' would end up having 'r' caps with the multifs
auth caps used as in the test
'test_multifs_single_client_cross_access_r_caps_end'.
This patch adds the conditional to validate the same.

This commit makes use of the PR ceph#64005

Fixes: https://tracker.ceph.com/issues/72167
Signed-off-by: Kotresh HR <khiremat@redhat.com>
(cherry picked from commit f10e34d)
kotreshhr added a commit to kotreshhr/ceph that referenced this pull request Sep 8, 2025
@kotreshhr
qa: Fix validation of client_version
980d8d5 
The multifs auth caps bug has a fix both in client and mds.
If it's old client and not patched, we expect that the fs
with 'rw' would end up having 'r' caps with the multifs
auth caps used as in the test
'test_multifs_single_client_cross_access_r_caps_end'.
This patch adds the conditional to validate the same.

This commit makes use of the PR ceph#64005

Fixes: https://tracker.ceph.com/issues/72167
Signed-off-by: Kotresh HR <khiremat@redhat.com>
(cherry picked from commit f10e34d)
kotreshhr added a commit to kotreshhr/ceph that referenced this pull request Sep 8, 2025
@kotreshhr
qa: Fix validation of client_version
9f26174 
The multifs auth caps bug has a fix both in client and mds.
If it's old client and not patched, we expect that the fs
with 'rw' would end up having 'r' caps with the multifs
auth caps used as in the test
'test_multifs_single_client_cross_access_r_caps_end'.
This patch adds the conditional to validate the same.

This commit makes use of the PR ceph#64005

Fixes: https://tracker.ceph.com/issues/72167
Signed-off-by: Kotresh HR <khiremat@redhat.com>
(cherry picked from commit f10e34d)

Conflicts:
  qa/tasks/cephfs/test_admin.py - The commit
     9d0ab23 is not backported
@kotreshhr kotreshhr mentioned this pull request Sep 18, 2025
Open
harsimran-05 pushed a commit to harsimran-05/ceph that referenced this pull request Oct 27, 2025
@kotreshhr @harsimran-05
qa: Fix validation of client_version
0c0f08b 
The multifs auth caps bug has a fix both in client and mds.
If it's old client and not patched, we expect that the fs
with 'rw' would end up having 'r' caps with the multifs
auth caps used as in the test
'test_multifs_single_client_cross_access_r_caps_end'.
This patch adds the conditional to validate the same.

This commit makes use of the PR ceph#64005

Fixes: https://tracker.ceph.com/issues/72167
Signed-off-by: Kotresh HR <khiremat@redhat.com>
harriscr pushed a commit to harriscr/ceph that referenced this pull request Nov 6, 2025
@kotreshhr
qa: Fix validation of client_version
7b80c88 
The multifs auth caps bug has a fix both in client and mds.
If it's old client and not patched, we expect that the fs
with 'rw' would end up having 'r' caps with the multifs
auth caps used as in the test
'test_multifs_single_client_cross_access_r_caps_end'.
This patch adds the conditional to validate the same.

This commit makes use of the PR ceph#64005

Fixes: https://tracker.ceph.com/issues/72167
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

@batrick batrick batrick approved these changes

@dparmar18 dparmar18 dparmar18 approved these changes

Assignees

No one assigned

Labels

cephfs Ceph File System tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kotreshhr @dparmar18 @vshankar @batrick