RGW - zipper - Remove target from get_obj_attrs() by dang · Pull Request #62787 · ceph/ceph

dang · 2025-04-11T16:24:25Z

The target argument to get_obj_attrs() was only used internally to RadosStore and DBStore, and never by callers of the API. Remove it entirely, to reduce API complexity.

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins test classic perf Jenkins Job | Jenkins Job Definition
jenkins test crimson perf Jenkins Job | Jenkins Job Definition
jenkins test signed Jenkins Job | Jenkins Job Definition
jenkins test make check Jenkins Job | Jenkins Job Definition
jenkins test make check arm64 Jenkins Job | Jenkins Job Definition
jenkins test submodules Jenkins Job | Jenkins Job Definition
jenkins test dashboard Jenkins Job | Jenkins Job Definition
jenkins test dashboard cephadm Jenkins Job | Jenkins Job Definition
jenkins test api Jenkins Job | Jenkins Job Definition
jenkins test docs ReadTheDocs | Github Workflow Definition
jenkins test ceph-volume all Jenkins Jobs | Jenkins Jobs Definition
jenkins test windows Jenkins Job | Jenkins Job Definition
jenkins test rook e2e Jenkins Job | Jenkins Job Definition

dang · 2025-04-14T13:38:51Z

jenkins test api

dang · 2025-04-14T13:39:03Z

jenkins test windows

value in get_obj_attrs() from backend store, using read_op->prepare() method. target_obj will be removed from get_obj_attrs as part of this PR: ceph#62787 and it was being used to get the object's instance value. so using read_op->prepare(), till this gets fixed Samarah identified that returning ENOENT when target_obj is NULL, is incorrect and suggested removing that. Signed-off-by: Samarah <samarah.uriarte@ibm.com> Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

github-actions · 2025-04-25T15:47:58Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

value in get_obj_attrs() from backend store, using read_op->prepare() method. target_obj will be removed from get_obj_attrs as part of this PR: ceph#62787 and it was being used to get the object's instance value. so using read_op->prepare(), till this gets fixed Samarah identified that returning ENOENT when target_obj is NULL, is incorrect and suggested removing that. Signed-off-by: Samarah <samarah.uriarte@ibm.com> Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

The target argument to get_obj_attrs() was only used internally to RadosStore and DBStore, and never by callers of the API. Remove it entirely, to reduce API complexity. Signed-off-by: Daniel Gryniewicz <dang@fprintf.net>

get_obj_attrs() gets the instance of the object, but isn't setting it into the Object. Do this, so that calling get_obj_attrs() ensures the instance is correct. Signed-off-by: Daniel Gryniewicz <dang@fprintf.net>

dang · 2025-05-01T17:22:08Z

@pritha-srivastava Please review the D4N bits.

pritha-srivastava · 2025-05-02T03:58:09Z

@pritha-srivastava Please review the D4N bits.

The D4N bits look fine to me, @samarahu : for testing the failure in D4N suite you can use this PR instead of the temp commit we created.

github-actions · 2025-07-01T05:04:26Z

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

github-actions · 2025-07-31T06:02:38Z

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

adamemerson · 2025-07-31T15:50:42Z

@pritha-srivastava @dang Do we still need this, and is anything blocking it if so?

dang · 2025-08-04T14:29:59Z

Yeah, we should still merge this. Needs review, though.

github-actions · 2025-10-03T15:02:14Z

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

anrao19 · 2025-10-17T06:15:12Z

pr testing completed and approved by @ivancich. Please find the details : https://tracker.ceph.com/issues/73370
@dang , if there is not further testing needed this can be merged. Please let me know

dang requested a review from a team as a code owner April 11, 2025 16:24

github-actions bot added the rgw label Apr 11, 2025

dang force-pushed the wip-dang-getattrs branch 2 times, most recently from bef2376 to 11e23d9 Compare April 18, 2025 17:34

github-actions bot added the needs-rebase label Apr 25, 2025

dang added 2 commits May 1, 2025 13:19

RGW - zipper - Remove target from get_obj_attrs()

f30a6a8

The target argument to get_obj_attrs() was only used internally to RadosStore and DBStore, and never by callers of the API. Remove it entirely, to reduce API complexity. Signed-off-by: Daniel Gryniewicz <dang@fprintf.net>

RGW - zipper - Set the instance in get_obj_attrs()

b8079bd

get_obj_attrs() gets the instance of the object, but isn't setting it into the Object. Do this, so that calling get_obj_attrs() ensures the instance is correct. Signed-off-by: Daniel Gryniewicz <dang@fprintf.net>

dang force-pushed the wip-dang-getattrs branch from 11e23d9 to b8079bd Compare May 1, 2025 17:21

github-actions bot added the tests label May 1, 2025

github-actions bot removed the needs-rebase label May 1, 2025

github-actions bot added the stale label Jul 1, 2025

github-actions bot closed this Jul 31, 2025

adamemerson reopened this Jul 31, 2025

github-actions bot removed the stale label Jul 31, 2025

github-actions bot added the stale label Oct 3, 2025

cbodley approved these changes Oct 3, 2025

View reviewed changes

cbodley added needs-qa and removed stale labels Oct 3, 2025

anrao19 added the wip-anrao3-testing label Oct 6, 2025

anrao19 added TESTED ready-to-merge and removed wip-anrao3-testing labels Oct 17, 2025

cbodley merged commit ddc8323 into ceph:main Oct 17, 2025
18 of 19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RGW - zipper - Remove target from get_obj_attrs()#62787

RGW - zipper - Remove target from get_obj_attrs()#62787
cbodley merged 2 commits intoceph:mainfrom
dang:wip-dang-getattrs

dang commented Apr 11, 2025 •

edited

Loading

Uh oh!

dang commented Apr 14, 2025

Uh oh!

dang commented Apr 14, 2025

Uh oh!

github-actions bot commented Apr 25, 2025

Uh oh!

dang commented May 1, 2025

Uh oh!

pritha-srivastava commented May 2, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

adamemerson commented Jul 31, 2025

Uh oh!

dang commented Aug 4, 2025

Uh oh!

github-actions bot commented Oct 3, 2025

Uh oh!

anrao19 commented Oct 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

dang commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution Guidelines

Checklist

Uh oh!

dang commented Apr 14, 2025

Uh oh!

dang commented Apr 14, 2025

Uh oh!

github-actions bot commented Apr 25, 2025

Uh oh!

dang commented May 1, 2025

Uh oh!

pritha-srivastava commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

adamemerson commented Jul 31, 2025

Uh oh!

dang commented Aug 4, 2025

Uh oh!

github-actions bot commented Oct 3, 2025

Uh oh!

anrao19 commented Oct 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dang commented Apr 11, 2025 •

edited

Loading

pritha-srivastava commented May 2, 2025 •

edited

Loading