Skip to content

Boost 1.87#61084

Merged
yuriw merged 2 commits intoceph:mainfrom
adamemerson:wip-boost-1.87
Mar 20, 2025
Merged

Boost 1.87#61084
yuriw merged 2 commits intoceph:mainfrom
adamemerson:wip-boost-1.87

Conversation

@adamemerson
Copy link
Contributor

@adamemerson adamemerson commented Dec 13, 2024 •
edited
Loading

For reasons of Python and Asio valgrinding.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@adamemerson adamemerson force-pushed the wip-boost-1.87 branch 3 times, most recently from 9065e41 to a70ab2e Compare January 7, 2025 02:51
@github-actions github-actions bot added the mgr label Jan 7, 2025
@adamemerson
Copy link
Contributor Author

adamemerson commented Jan 7, 2025

@cbodley Can you take a look at this? GCC marks an error at https://github.com/adamemerson/ceph/blob/wip-boost-1.87/src/librbd/migration/HttpClient.cc#L969 and I'm not quite sure where it's going wrong. Asio is failing to move-construct a Beast stream, it appears.

@Matan-B
Copy link
Contributor

Matan-B commented Feb 9, 2025

seastar should be ok with: #61735

I get multiple warnings of:

boost/include/boost/detail/atomic_count.hpp:10:1: note: ‘#pragma message: This header is deprecated. Use <boost/smart_ptr/detail/atomic_count.hpp> instead.’
   10 | BOOST_HEADER_DEPRECATED("<boost/smart_ptr/detail/atomic_count.hpp>")

Did you have these as well?

bazaah added a commit to bazaah/aur-ceph that referenced this pull request Feb 10, 2025
@bazaah
repo: add boost-1.87-fixes.patch
60377de 
fix a bunch of stuff that boost 1.87 broke around boost::asio, largely
involving deprecated function overloads being removed.

I did this independently of the upstream, but I realized belatedly that
I should have just looked in the PR lists first, as 90% of the fixes
already existed, unmerged.

References: ceph/ceph#61084
@adamemerson
Copy link
Contributor Author

adamemerson commented Feb 10, 2025

seastar should be ok with: #61735

I get multiple warnings of:

boost/include/boost/detail/atomic_count.hpp:10:1: note: ‘#pragma message: This header is deprecated. Use <boost/smart_ptr/detail/atomic_count.hpp> instead.’
   10 | BOOST_HEADER_DEPRECATED("<boost/smart_ptr/detail/atomic_count.hpp>")

Did you have these as well?

Yes. I think some of the less maintained parts of boost use deprecated constructs. It is very annoying. Spirit and MPI seem to be the worst offenders. Short term I was thinking of suppressing the warnings around includes of things we don't control.

Long term I'd like us to replace our uses of Boost.Spirit and similar pre-Modern Boost libraries that have been accumulating more flakiness as we upgrade.

But we don't have to worry about that for now.

@Matan-B Matan-B mentioned this pull request Feb 11, 2025
Merged
14 tasks
@adamemerson
Copy link
Contributor Author

adamemerson commented Mar 10, 2025

@petrutlucian94 Do you know what might be up with the windows failure here? It looks like Boost is expecting a header that isn't there?

@adamemerson adamemerson marked this pull request as ready for review March 11, 2025 00:49
@adamemerson
Copy link
Contributor Author

adamemerson commented Mar 11, 2025

@ljflores Could we get this tested against core, please?

@petrutlucian94
Copy link
Contributor

petrutlucian94 commented Mar 11, 2025

@adamemerson I see that it was fixed here: boostorg/stacktrace@d6499f2

It wasn't released yet so we'll need to apply the fix ourselves through patch or sed.

@github-actions
Copy link

github-actions bot commented Mar 11, 2025

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@adamemerson
build: Upgrade to Boost 1.87
b446290 
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
@adamemerson
build: Pass -DBOOST_ALLOW_DEPRECATED_HEADERS to compiler
f9a687a 
Because Boost including its own deprecated headers is not our problem.

Signed-off-by: Adam Emerson <aemerson@redhat.com>
@jmundack
Copy link
Contributor

jmundack commented Mar 12, 2025

#62242 - fixed the error in make check

running it again

@jmundack
Copy link
Contributor

jmundack commented Mar 12, 2025

jenkins test make check

@jmundack
Copy link
Contributor

jmundack commented Mar 12, 2025

jenkins test make check arm64

2 similar comments
@jmundack
Copy link
Contributor

jmundack commented Mar 13, 2025

jenkins test make check arm64

@jmundack
Copy link
Contributor

jmundack commented Mar 13, 2025

jenkins test make check arm64

@adamemerson
Copy link
Contributor Author

adamemerson commented Mar 14, 2025

@cbodley Between

https://pulpito.ceph.com/aemerson-2025-03-13_06:04:34-rgw-wip-boost-1.87-distro-default-smithi/

and

https://pulpito.ceph.com/aemerson-2025-03-13_15:10:21-rgw-wip-boost-1.87-distro-default-smithi/

and the lone failure being a known fault, can we count this as QAd successfully for RGW?

@cbodley
Copy link
Contributor

cbodley commented Mar 14, 2025

can we count this as QAd successfully for RGW?

👍

@adamemerson adamemerson added the cephfs Ceph File System label Mar 14, 2025
@ljflores
Copy link
Member

ljflores commented Mar 20, 2025

Rados approved: https://tracker.ceph.com/projects/rados/wiki/MAIN#httpstrackercephcomissues70485

@yuriw yuriw merged commit 5534356 into ceph:main Mar 20, 2025
11 checks passed
Matan-B added a commit to Matan-B/ceph that referenced this pull request Mar 31, 2025
@Matan-B
cmake/modules/FindBoost.cmake: fix Boost_NO_WARN_NEW_VERSIONS
9cb8a4d 
ceph#61084 bumped up the version used to
1.87. The warning should be for 1.88, same as it was 1.86 when we used
1.85.

Fixes: https://tracker.ceph.com/issues/70725

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B mentioned this pull request Mar 31, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Matan-B Matan-B Matan-B approved these changes

Assignees

No one assigned

Labels

build/ops common core needs-qa rbd wip-yuri13-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@adamemerson @Matan-B @petrutlucian94 @jmundack @cbodley @ljflores @yuriw