Skip to content

reef: cephfs-top: fix exceptions on small/large sized windows#59898

Merged
mchangir merged 2 commits intoceph:reeffrom
joscollin:wip-68167-reef
Feb 4, 2025
Merged

reef: cephfs-top: fix exceptions on small/large sized windows#59898
mchangir merged 2 commits intoceph:reeffrom
joscollin:wip-68167-reef

Conversation

@joscollin
Copy link
Member

backport tracker: https://tracker.ceph.com/issues/68167


backport of #59566
parent tracker: https://tracker.ceph.com/issues/67859

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

Fixes "exception: curses function returned NULL"
when the window width is larger than expected.

Fixes: https://tracker.ceph.com/issues/67859
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit a59f007)
Fixes "exception: addwstr() returned ERR"
when the window width is smaller than expected.

Fixes: https://tracker.ceph.com/issues/67859
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit 926f91c)
@joscollin joscollin added this to the reef milestone Sep 20, 2024
@joscollin joscollin added the cephfs Ceph File System label Sep 20, 2024
@joscollin
Copy link
Member Author

jenkins test make check

@joscollin
Copy link
Member Author

jenkins test windows

1 similar comment
@joscollin
Copy link
Member Author

jenkins test windows

@joscollin joscollin requested a review from a team September 22, 2024 05:44
@joscollin
Copy link
Member Author

jenkins test windows

@joscollin
Copy link
Member Author

@vshankar ping

@joscollin
Copy link
Member Author

jenkins test windows

@vshankar
Copy link
Contributor

This PR is under test in https://tracker.ceph.com/issues/69503.

vshankar added a commit to vshankar/ceph that referenced this pull request Jan 13, 2025
* refs/pull/59898/head:
	cephfs-top: fix exception on small sized windows
	cephfs-top: fix exception on large sized windows
Copy link
Contributor

@mchangir mchangir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mchangir mchangir merged commit 115f9e8 into ceph:reef Feb 4, 2025
@joscollin joscollin deleted the wip-68167-reef branch February 4, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants