Project

General

Profile

Actions
Copy link

Bug #67859

closed

cephfs-top: fix exceptions on small/large sized windows

Added by Jos Collin over 1 year ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jos Collin
Category:
Correctness/Safety
Target version:
Ceph - v20.0.0
% Done:

0%

Source:
Community (dev)
Backport:
reef,squid
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
cephfs-top
Labels (FS):
Pull request ID:
59566
Tags (freeform):
backport_processed
Merge Commit:
e0b974a06a5d32671c765c6999e0dcdcf26fb23f
Fixed In:
v19.3.0-5090-ge0b974a06a
Released In:
v20.2.0~1972
Upkeep Timestamp:
2025-11-01T01:27:42+00:00

Description

Running cephfs-top on my 32 inch horizontal monitor causes 

exception: curses function returned NULL
as the window width is larger than expected on wider monitors.
This doesn't happen on medium sized windows and PAD_WIDTH = 300 is much more appropriate for medium sized windows and appropriate for the number of columns displayed in cephfs-top.

Also cephfs-top shows exception on small sized windows, when it doesn't have enough space to create header 

exception: addwstr() returned ERR
. This is fine, but need to handle the exception better.

Related issues 2 (0 open — 2 closed)

Copied to CephFS - Backport #68167: reef: cephfs-top: fix exceptions on small/large sized windowsResolvedJos CollinActions
Copied to CephFS - Backport #68168: squid: cephfs-top: fix exceptions on small/large sized windowsResolvedJos CollinActions
Actions
Copy link
 #1

Updated by Jos Collin over 1 year ago

  • Pull request ID set to 59566
Actions
Copy link
 #2

Updated by Jos Collin over 1 year ago

  • Subject changed from cephfs-top: fix exception in large sized windows to cephfs-top: fix exceptions on small/large sized windows
  • Description updated (diff)
Actions
Copy link
 #3

Updated by Jos Collin over 1 year ago

  • Description updated (diff)
Actions
Copy link
 #4

Updated by Jos Collin over 1 year ago

  • Status changed from In Progress to Fix Under Review
Actions
Copy link
 #5

Updated by Venky Shankar over 1 year ago

  • Status changed from Fix Under Review to Pending Backport
  • Target version set to v20.0.0
Actions
Copy link
 #6

Updated by Upkeep Bot over 1 year ago

  • Copied to Backport #68167: reef: cephfs-top: fix exceptions on small/large sized windows added
Actions
Copy link
 #7

Updated by Upkeep Bot over 1 year ago

  • Copied to Backport #68168: squid: cephfs-top: fix exceptions on small/large sized windows added
Actions
Copy link
 #8

Updated by Upkeep Bot over 1 year ago

  • Tags (freeform) set to backport_processed
Actions
Copy link
 #9

Updated by Jos Collin about 1 year ago

  • Status changed from Pending Backport to Resolved
Actions
Copy link
 #10

Updated by Patrick Donnelly 9 months ago

  • Merge Commit set to e0b974a06a5d32671c765c6999e0dcdcf26fb23f
  • Fixed In set to v19.3.0-5090-ge0b974a06a5d
Actions
Copy link
 #11

Updated by Upkeep Bot 9 months ago

  • Fixed In changed from v19.3.0-5090-ge0b974a06a5d to v19.3.0-5090-ge0b974a06a5
  • Upkeep Timestamp set to 2025-07-08T18:29:39+00:00
Actions
Copy link
 #12

Updated by Upkeep Bot 8 months ago

  • Fixed In changed from v19.3.0-5090-ge0b974a06a5 to v19.3.0-5090-ge0b974a06a
  • Upkeep Timestamp changed from 2025-07-08T18:29:39+00:00 to 2025-07-14T17:10:20+00:00
Actions
Copy link
 #13

Updated by Upkeep Bot 5 months ago

  • Released In set to v20.2.0~1972
  • Upkeep Timestamp changed from 2025-07-14T17:10:20+00:00 to 2025-11-01T01:27:42+00:00
Actions
Copy link

Also available in: Atom PDF