osd/scrub: reduce osd_requested_scrub_priority default value#59793
Merged
osd/scrub: reduce osd_requested_scrub_priority default value#59793
Conversation
No scrub messages should have a higher priority than client op messages. The default value should therefore be below osd_client_op_priority, which is 63. But as a followup PR would eliminate the special queue priority for 'requested' scrub messages, the default value is set to equal osd_scrub_priority. Fixes: https://tracker.ceph.com/issues/68072 Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Member
|
jenkins test make check |
athanatos
approved these changes
Sep 19, 2024
amathuria
approved these changes
Sep 19, 2024
This was referenced Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No scrub messages should have a higher priority than client op messages. The default value should therefore be below osd_client_op_priority, which is 63.
But as a followup PR would eliminate the special queue priority for 'requested' scrub messages, the default value is set to equal osd_scrub_priority.
Fixes: https://tracker.ceph.com/issues/68072
Note: in 'main', this change is to be superseded by #59641.
#59793 was created (and will be merged) as a path for backporting only this part of change to
squid & reef.