osd/scrub: disable high work-queue priority for high-prio scrubs#59641
Merged
osd/scrub: disable high work-queue priority for high-prio scrubs#59641
Conversation
Contributor
anthonyeleven
left a comment
There was a problem hiding this comment.
LGTM but I'm not qualified to approve the code
athanatos
approved these changes
Sep 12, 2024
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
Prior to this fix, scrub-related messages were queued with one of four priorities: - if part of a regular, periodic scrub, the messages were queued with a very low priority (osd_scrub_priority. Default: 5), unless: - if the pool configuration specified a higher priority for the scrub, the messages were queued with that priority (the SCRUB_PRIORITY pool configuration option); - if a client operation was waiting for the scrub to complete, the messages were queued with the higher priority of the client ops (osd_client_op_priority. Default: 63); and if the scrub was a high-priority one, e.g. initiated by the operator, the messages were queued with the highest priority (osd_requested_scrub_priority. Default: 120). That last priority is too high, as scrubs should not have precedence over client ops. It is even more disruptive if the cluster is set to have only manually initiated scrubs, and all scrubs are high-priority ones. This patch removes the osd_requested_scrub_priority. Instead, all scrub messages are queued according to the first three rules above. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
75cbaab to
3be4300
Compare
Contributor
Author
|
Merging based on my Teuthology tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this fix, scrub-related messages were queued with one of four priorities:
if part of a regular, periodic scrub, the messages were queued with a very low priority (osd_scrub_priority. Default: 5), unless:
if the pool configuration specified a higher priority for the scrub, the messages were queued with that priority (the SCRUB_PRIORITY pool configuration option);
if a client operation was waiting for the scrub to complete, the messages were queued with the higher priority of the client ops (osd_client_op_priority. Default: 63);
and if the scrub was a high-priority one, e.g. initiated by the operator, the messages were queued with the highest priority (osd_requested_scrub_priority. Default: 120).
That last priority is too high, as scrubs should not have precedence over client ops. It is even more disruptive if the cluster is set to have only manually initiated scrubs, and all scrubs are high-priority ones.
This patch removes the osd_requested_scrub_priority. Instead, all scrub messages are queued according to the first three rules above.