Skip to content

mgr/snap_schedule: fix typo in error message during retention add#59161

Merged
vshankar merged 2 commits intoceph:mainfrom
mchangir:mgr-snap_schedule-fix-typo-in-error-message-2
May 26, 2025
Merged

mgr/snap_schedule: fix typo in error message during retention add#59161
vshankar merged 2 commits intoceph:mainfrom
mchangir:mgr-snap_schedule-fix-typo-in-error-message-2

Conversation

@mchangir
Copy link
Contributor

@mchangir mchangir commented Aug 12, 2024 •
edited
Loading

  • correction to the error message during retention add
  • new test case to test the rejection of duplicate retention

Fixes: https://tracker.ceph.com/issues/64042
Signed-off-by: Milind Changire mailto:mchangir@redhat.com

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@mchangir
mgr/snap_schedule: fix message format error
59ec7a9 
Fixes: https://tracker.ceph.com/issues/64042
Signed-off-by: Milind Changire <mchangir@redhat.com>
@mchangir
qa: test failure for duplicate retention spec
074f05a 
Signed-off-by: Milind Changire <mchangir@redhat.com>
@github-actions github-actions bot added cephfs Ceph File System pybind tests labels Aug 12, 2024
@mchangir
Copy link
Contributor Author

mchangir commented Aug 12, 2024

continued from #55193

@chrisphoffman chrisphoffman requested a review from a team August 22, 2024 19:21
chrisphoffman
chrisphoffman approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@chrisphoffman chrisphoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@batrick
Copy link
Member

batrick commented Aug 29, 2024

jenkins test make check

@batrick
Copy link
Member

batrick commented Aug 29, 2024

jenkins test make check arm64

@mchangir
Copy link
Contributor Author

mchangir commented Sep 3, 2024

jenkins test make check

@vshankar vshankar self-assigned this Nov 5, 2024
@vshankar
Copy link
Contributor

vshankar commented Nov 12, 2024

cc @mchangir for QA testing.

@github-actions
Copy link

github-actions bot commented Jan 11, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Jan 11, 2025
@vshankar
Copy link
Contributor

vshankar commented Jan 15, 2025

This PR is under test in https://tracker.ceph.com/issues/69546.

@github-actions github-actions bot removed the stale label Jan 15, 2025
@vshankar
Copy link
Contributor

vshankar commented Jan 27, 2025

I see a failed snap_schedule test which is possibly related to this change

Dropping from test branch till @mchangir investigates.

@mchangir
Copy link
Contributor Author

mchangir commented Jan 27, 2025

I see a failed snap_schedule test which is possibly related to this change

Dropping from test branch till @mchangir investigates.

The failing snap-schedule test was due to duplicate infra code.
It has been fixed in #57263.

@github-actions
Copy link

github-actions bot commented Mar 28, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Mar 28, 2025
@mchangir mchangir removed the stale label Mar 31, 2025
@vshankar
Copy link
Contributor

vshankar commented May 8, 2025

This PR is under test in https://tracker.ceph.com/issues/71260.

@vshankar
Copy link
Contributor

vshankar commented May 15, 2025

This PR is under test in https://tracker.ceph.com/issues/71260.

Suite run looks good. This will be merged soon.

@vshankar
Copy link
Contributor

vshankar commented May 15, 2025

jenkins test make check arm64

vshankar
vshankar approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tracker.ceph.com/projects/cephfs/wiki/QA_main_2025#wip-vshankar-testing-20250508200127-debug

@vshankar
Copy link
Contributor

vshankar commented May 20, 2025

jenkins test make check arm64

@vshankar
Copy link
Contributor

vshankar commented May 23, 2025

@mchangir not sure why the .qa check isn't running to completion :/

@mchangir
Copy link
Contributor Author

mchangir commented May 23, 2025

jenkins retest this please

@mchangir mchangir changed the title mgr: snap schedule fix typo in error message during retention add mgr/snap_schedule: fix typo in error message during retention add May 26, 2025
@mchangir
Copy link
Contributor Author

mchangir commented May 26, 2025

@vshankar fyi - all checks have passed

@vshankar vshankar merged commit 1275f1a into ceph:main May 26, 2025
8 checks passed
@mchangir mchangir mentioned this pull request Jun 17, 2025
Merged
This was referenced Aug 29, 2025
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

@chrisphoffman chrisphoffman chrisphoffman approved these changes

Assignees

@vshankar vshankar

Labels

cephfs Ceph File System needs-review pybind tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mchangir @batrick @vshankar @chrisphoffman