Skip to content

mgr/snap_schedule: restrict retention period multipliers set#57263

Merged
vshankar merged 4 commits intoceph:mainfrom
mchangir:mgr-snap_schedule-restrict-retention-period-multiplier-set
Dec 5, 2025
Merged

mgr/snap_schedule: restrict retention period multipliers set#57263
vshankar merged 4 commits intoceph:mainfrom
mchangir:mgr-snap_schedule-restrict-retention-period-multiplier-set

Conversation

@mchangir
Copy link
Contributor

@mchangir mchangir commented May 4, 2024 •
edited
Loading

Fixes: https://tracker.ceph.com/issues/65801
Signed-off-by: Milind Changire mchangir@redhat.com

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@github-actions github-actions bot added the pybind label May 4, 2024
@mchangir mchangir force-pushed the mgr-snap_schedule-restrict-retention-period-multiplier-set branch from f0c3447 to 95cbd22 Compare May 8, 2024 11:26
@github-actions github-actions bot added cephfs Ceph File System tests labels May 8, 2024
@mchangir
Copy link
Contributor Author

mchangir commented May 8, 2024

rebased and added qa commit

@github-actions
Copy link

github-actions bot commented Jul 7, 2024

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Jul 7, 2024
@vshankar vshankar requested a review from a team July 16, 2024 05:07
vshankar
vshankar reviewed Jul 16, 2024
View reviewed changes
@github-actions github-actions bot removed the stale label Jul 16, 2024
@mchangir mchangir force-pushed the mgr-snap_schedule-restrict-retention-period-multiplier-set branch from 95cbd22 to be4a0f3 Compare November 12, 2024 06:23
vshankar
vshankar approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@github-actions
Copy link

github-actions bot commented Jan 12, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Jan 12, 2025
@vshankar
Copy link
Contributor

vshankar commented Jan 15, 2025

This PR is under test in https://tracker.ceph.com/issues/69546.

@github-actions github-actions bot removed the stale label Jan 15, 2025
@vshankar
Copy link
Contributor

vshankar commented Jan 27, 2025

I see a failed snap_schedule test which is possibly related to this change

Dropping from test branch till @mchangir investigates.

@mchangir mchangir force-pushed the mgr-snap_schedule-restrict-retention-period-multiplier-set branch from be4a0f3 to 8bcd676 Compare January 27, 2025 09:22
@mchangir
Copy link
Contributor Author

mchangir commented Jan 27, 2025

  • removed duplicate definition of def remove_snapshots()
  • revised usage of remove_snapshots()

@mchangir mchangir mentioned this pull request Jan 27, 2025
Merged
14 tasks
@github-actions
Copy link

github-actions bot commented Mar 28, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Mar 28, 2025
@mchangir mchangir removed the stale label Mar 31, 2025
@vshankar
Copy link
Contributor

vshankar commented Apr 7, 2025

This PR is under test in https://tracker.ceph.com/issues/70820.

@vshankar
Copy link
Contributor

vshankar commented Apr 21, 2025

Test runs looks fine. Preparing run wiki and this should get merged soon.

@vshankar
Copy link
Contributor

vshankar commented Apr 21, 2025

jenkins retest this please

@github-actions github-actions bot added the stale label Jul 5, 2025
mchangir added 3 commits July 8, 2025 06:56
@mchangir
mgr/snap_schedule: restrict retention period multipliers set
32ced0c 
Fixes: https://tracker.ceph.com/issues/65801
Signed-off-by: Milind Changire <mchangir@redhat.com>
@mchangir
qa: remove possibly created snapshots
272a67c 
Signed-off-by: Milind Changire <mchangir@redhat.com>
@mchangir
qa: test for bad retention period specifiers
e42339d 
Signed-off-by: Milind Changire <mchangir@redhat.com>
@mchangir mchangir force-pushed the mgr-snap_schedule-restrict-retention-period-multiplier-set branch from 8bcd676 to e42339d Compare July 8, 2025 01:28
@mchangir
qa: deactivate snap-schedule to avoid race with snap delete
4d9d11c 
Signed-off-by: Milind Changire <mchangir@redhat.com>
@mchangir mchangir removed the stale label Jul 8, 2025
@mchangir
Copy link
Contributor Author

mchangir commented Jul 21, 2025

jenkins test make check

@mchangir
Copy link
Contributor Author

mchangir commented Jul 21, 2025

@vshankar please take this up for retest

@github-actions
Copy link

github-actions bot commented Sep 19, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Sep 19, 2025
@github-actions
Copy link

github-actions bot commented Oct 19, 2025

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Oct 19, 2025
@mchangir mchangir reopened this Oct 20, 2025
@mchangir
Copy link
Contributor Author

mchangir commented Oct 20, 2025

@joscollin please take this up for retest if you are scheduling tests for the main branch

@github-actions github-actions bot removed the stale label Oct 20, 2025
@joscollin
Copy link
Member

joscollin commented Oct 21, 2025

@joscollin please take this up for retest if you are scheduling tests for the main branch

No @mchangir. I'm not scheduling tests for the main branch.

@vshankar
Copy link
Contributor

vshankar commented Nov 4, 2025

jenkins retest this please

@vshankar
Copy link
Contributor

vshankar commented Nov 20, 2025

This PR is under test in https://tracker.ceph.com/issues/73938.

@vshankar
Copy link
Contributor

vshankar commented Dec 1, 2025

Need to retest with https://tracker.ceph.com/issues/74026

vshankar added a commit to vshankar/ceph that referenced this pull request Dec 2, 2025
@vshankar
Merge PR ceph#57263 into wip-vshankar-testing-20251202.044501
9965f70 
* refs/pull/57263/head:

Reviewed-by: Venky Shankar <vshankar@redhat.com>
@vshankar vshankar self-assigned this Dec 2, 2025
vshankar
vshankar approved these changes Dec 5, 2025
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tracker.ceph.com/projects/cephfs/wiki/QA_main_2025#wip-vshankar-testing-20251120083629-debug

@vshankar vshankar merged commit 5d63807 into ceph:main Dec 5, 2025
20 checks passed
This was referenced Dec 15, 2025
Closed
Closed
This was referenced Jan 12, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

Assignees

@vshankar vshankar

Labels

cephfs Ceph File System needs-review pybind tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mchangir @vshankar @joscollin