mgr/snap_schedule: fix message format error#55193
mgr/snap_schedule: fix message format error#55193
Conversation
c2bd7fa to
f8a6862
Compare
|
jenkins test api |
Fixes: https://tracker.ceph.com/issues/64042 Signed-off-by: Milind Changire <mchangir@redhat.com>
Signed-off-by: Milind Changire <mchangir@redhat.com>
f8a6862 to
e7a63bd
Compare
| retention_count='50') | ||
|
|
||
| # Adding a duplicate retention spec should fail | ||
| with self.assertRaises(CommandFailedError): |
There was a problem hiding this comment.
Agree! We can add someting like: self.assertEqual(exception status returned, code) to do that.
There was a problem hiding this comment.
Agree! We can add someting like:
self.assertEqual(exception status returned, code)to do that.
Well, the exception is thrown from the snap-schedule manager module code which eventually causes the command to fail. The teuthology code can just detect that the command has failed with non-zero status ... but can't catch the exception ?
Am I missing something ? or do you want to test the process exit code with errno.EEXIST?
There was a problem hiding this comment.
Sounds like what @mchangir is telling here makes sense. @dparmar18 @neesingh-rh What's pending?
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
Fixes: https://tracker.ceph.com/issues/64042
Signed-off-by: Milind Changire mchangir@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e