Skip to content

build: Bump boost version to 1.85#57581

Merged
cbodley merged 5 commits intoceph:mainfrom
adamemerson:wip-boost-1.85
Jun 27, 2024
Merged

build: Bump boost version to 1.85#57581
cbodley merged 5 commits intoceph:mainfrom
adamemerson:wip-boost-1.85

Conversation

@adamemerson
Copy link
Contributor

@adamemerson adamemerson commented May 20, 2024 •
edited
Loading

Needed to fix some bugs in Boost.Asio, particularly one related to asio::spawn.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@adamemerson adamemerson requested a review from cbodley May 20, 2024 23:18
@adamemerson adamemerson requested a review from a team as a code owner May 20, 2024 23:54
@github-actions github-actions bot added the rgw label May 20, 2024
@adamemerson
Copy link
Contributor Author

adamemerson commented May 21, 2024

jenkins test api

@adamemerson
Copy link
Contributor Author

adamemerson commented May 21, 2024

jenkins test make check arm64

@adamemerson
Copy link
Contributor Author

adamemerson commented May 21, 2024

jenkins test windows

cbodley
cbodley reviewed May 21, 2024
View reviewed changes
src/mds/BoostUrlImpl.cc
* to link a program to a static or dynamic Boost.URL library,
* simply place the following line in exactly one source file in your project.
*/
#include <boost/url/src.hpp>
Copy link
Contributor

@cbodley cbodley May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @leonid-s-usov

the 1.85 docs now say:

Boost.URL is a compiled library. You need to link your program with the Boost.URL built library. You must install binaries in a location that can be found by your linker.

Copy link
Contributor

@leonid-s-usov leonid-s-usov May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I love it!

@adamemerson
Copy link
Contributor Author

adamemerson commented May 21, 2024

jenkins render docs

leonid-s-usov
leonid-s-usov approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@leonid-s-usov leonid-s-usov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good CephFS-wise; make check is sufficient to validate it.

@adamemerson
Copy link
Contributor Author

adamemerson commented May 21, 2024

jenkins test windows

@adamemerson
mds: Use Boost::url rather than src.hpp
857eedb 
As `src.hpp` is no longer supported.

Signed-off-by: Adam Emerson <aemerson@redhat.com>
@adamemerson
build: Make boost_url a list
3543542 
Cmake 3.29 does not appreciate a space separated string being
substituted in.

Signed-off-by: Adam Emerson <aemerson@redhat.com>
@adamemerson
build: Prefer Ceph's mirror of boost and add boost archive
dd54e6b 
Since jfrog goes down from time to time, put it last in the list for
now.

Signed-off-by: Adam Emerson <aemerson@redhat.com>
@adamemerson
build: Bump Boost to 1.85
3d36ac2 
Signed-off-by: Adam Emerson <aemerson@redhat.com>
@adamemerson
submodule: Remove boost_redis submodule
862246c 
This is no longer needed as Boost 1.85 contains Boost.Redis.

Signed-off-by: Adam Emerson <aemerson@redhat.com>
@adamemerson
Copy link
Contributor Author

adamemerson commented May 23, 2024

jenkins test api

@adamemerson
Copy link
Contributor Author

adamemerson commented May 23, 2024

jenkins test make check arm64

@adamemerson
Copy link
Contributor Author

adamemerson commented May 23, 2024

Builds clean on Shaman

https://shaman.ceph.com/builds/ceph/wip-boost-1.85/862246cdefc12acfbd2711c7677a252c59634c9d/

@adamemerson
Copy link
Contributor Author

adamemerson commented May 23, 2024

jenkins test api

@adamemerson
Copy link
Contributor Author

adamemerson commented May 23, 2024

@cbodley Do we need any test suites?

@cbodley
Copy link
Contributor

cbodley commented May 23, 2024

@cbodley Do we need any test suites?

last time in #51573 we validated with the rados suite

@cbodley
Copy link
Contributor

cbodley commented May 23, 2024

@yuriw @ljflores can i request your assistance with a rados suite run?

batrick
batrick approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this be backported to squid? If so, we do need a tracker ticket. Also maybe just update mds: Use Boost::url rather than src.hpp with Fixes: https://tracker.ceph.com/issues/66163.

@cbodley
Copy link
Contributor

cbodley commented May 30, 2024

Will this be backported to squid?

we're not planning to backport, no

@batrick
Copy link
Member

batrick commented Jun 11, 2024

jenkins test make check arm64

@batrick
Copy link
Member

batrick commented Jun 11, 2024

This PR is under test in https://tracker.ceph.com/issues/66433.

@batrick
Copy link
Member

batrick commented Jun 12, 2024

jenkins test make check arm64

@batrick
Copy link
Member

batrick commented Jun 13, 2024

This PR is under test in https://tracker.ceph.com/issues/66462.

batrick added a commit to batrick/ceph that referenced this pull request Jun 13, 2024
@batrick
Merge PR ceph#57581 into wip-pdonnell-testing-20240613.014923-debug
7595d88 
* refs/pull/57581/head:
	submodule: Remove boost_redis submodule
	build: Bump Boost to 1.85
	build: Prefer Ceph's mirror of boost and add boost archive
	build: Make boost_url a list
	mds: Use Boost::url rather than `src.hpp`
@batrick
Copy link
Member

batrick commented Jun 18, 2024

This PR is under test in https://tracker.ceph.com/issues/66462.

I didn't see any surprises from the fs suite.

This was referenced Jun 21, 2024
Closed
Closed
@amathuria
Copy link
Contributor

amathuria commented Jun 27, 2024

Rados approved: https://tracker.ceph.com/projects/rados/wiki/MAIN#httpstrackercephcomissues66265

@cbodley cbodley merged commit 0a1d093 into ceph:main Jun 27, 2024
This was referenced Jun 27, 2024
Merged
Merged
Merged
@zhscn
Copy link
Member

zhscn commented Aug 16, 2024

Boost.flat_map introduced a bug in 1.85 boostorg/container#273. The result of grep shows that the flat_map is used in some places. Given that Boost 1.86 was released a few days ago https://www.boost.org/users/history/version_1_86_0.html , perhaps we should consider updating again? Downgrading to 1.84 is also a choice.

bazaah added a commit to bazaah/aur-ceph that referenced this pull request Oct 4, 2024
@bazaah
repo: add backport-mds-link-boost-urls.patch
3d48e6b 
It seems the previous header-only version of Boost.Url no longer is
supported, so we need to link it into the mds bin.

This partially backports the change from an larger PR, modified to work
with 19.2.0 over refs/main

References: https://github.com/boostorg/url/blob/boost-1.85.0/include/boost/url/src.hpp
References: ceph/ceph#57581
Upstream-ref: ceph/ceph@857eedb
bazaah added a commit to bazaah/aur-ceph that referenced this pull request Oct 6, 2024
@bazaah
repo: add backport-mds-link-boost-urls.patch
ceb3111 
It seems the previous header-only version of Boost.Url no longer is
supported, so we need to link it into the mds bin.

This partially backports the change from an larger PR, modified to work
with 19.2.0 over refs/main

References: https://github.com/boostorg/url/blob/boost-1.85.0/include/boost/url/src.hpp
References: ceph/ceph#57581
Upstream-ref: ceph/ceph@857eedb
bazaah added a commit to bazaah/aur-ceph that referenced this pull request Feb 6, 2025
@bazaah
repo: add backport-mds-link-boost-urls.patch
e5a8cd0 
It seems the previous header-only version of Boost.Url no longer is
supported, so we need to link it into the mds bin.

This partially backports the change from an larger PR, modified to work
with 19.2.0 over refs/main

References: https://github.com/boostorg/url/blob/boost-1.85.0/include/boost/url/src.hpp
References: ceph/ceph#57581
Upstream-ref: ceph/ceph@857eedb
bazaah added a commit to bazaah/aur-ceph that referenced this pull request Feb 8, 2025
@bazaah
repo: add backport-mds-link-boost-urls.patch
fa36a45 
It seems the previous header-only version of Boost.Url no longer is
supported, so we need to link it into the mds bin.

This partially backports the change from an larger PR, modified to work
with 19.2.0 over refs/main

References: https://github.com/boostorg/url/blob/boost-1.85.0/include/boost/url/src.hpp
References: ceph/ceph#57581
Upstream-ref: ceph/ceph@857eedb
@adamemerson adamemerson deleted the wip-boost-1.85 branch March 11, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@batrick batrick batrick approved these changes

@cbodley cbodley cbodley approved these changes

+1 more reviewer

@leonid-s-usov leonid-s-usov leonid-s-usov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build/ops cephfs Ceph File System core needs-qa rgw tests wip-yuri4-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@adamemerson @cbodley @batrick @amathuria @zhscn @leonid-s-usov @ljflores