Skip to content

build: Bump boost to 1.82#51573

Merged
yuriw merged 1 commit intoceph:mainfrom
adamemerson:wip-boost-the-boost
Jul 11, 2023
Merged

build: Bump boost to 1.82#51573
yuriw merged 1 commit intoceph:mainfrom
adamemerson:wip-boost-the-boost

Conversation

@adamemerson
Copy link
Contributor

@adamemerson adamemerson commented May 18, 2023 •
edited
Loading

Needed to fix coroutine detection under Clang

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@adamemerson adamemerson requested a review from a team as a code owner May 18, 2023 15:47
@github-actions github-actions bot added the rgw label May 18, 2023
@adamemerson
Copy link
Contributor Author

adamemerson commented May 18, 2023

Jenkins, retest this please

@adamemerson
Copy link
Contributor Author

adamemerson commented May 19, 2023

jenkins test api

@cbodley cbodley added the core label May 31, 2023
@ljflores
Copy link
Member

ljflores commented Jun 16, 2023

Hey @adamemerson, when we try to start a build for this in Shaman, it fails from
https://jenkins.ceph.com/job/ceph-dev-new-setup/71572/console

ceph-18.0.0-4409-gcb52cb90/src/.git_version
ceph-18.0.0-4409-gcb52cb90/ceph.spec
2023-06-16 16:55:19 URL:https://jfrog-prod-usw2-shared-oregon-main.s3.amazonaws.com/aol-boostorg/filestore/5c/5c0736ce8d6f0d21275a1d9407dce48e6decce6a?X-Artifactory-username=anonymous&X-Artifactory-repoType=local&X-Artifactory-repositoryKey=main&X-Artifactory-packageType=generic&X-Artifactory-artifactPath=release%2F1.82.0%2Fsource%2Fboost_1_82_0.tar.bz2&X-Artifactory-projectKey=default&x-jf-traceId=e80827ce537d547f&response-content-disposition=attachment%3Bfilename%3D%22boost_1_82_0.tar.bz2%22&response-content-type=application%2Fx-bzip2&X-Amz-Security-Token=IQoJb3JpZ2luX2VjEPH%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLXdlc3QtMiJHMEUCIQCarxp966I7oP5hCFpWmt6ZJfw15IL%2FN2xnuXzARXF3OAIgWuc4ya3Oa6epbuZP2%2BrrA8YfPe3FXOotroR%2BjUWIYxkqhgUIShAAGgwxNTIxNTMwNjIxNDEiDH%2BBKIX9NjUswGTixCrjBEKOOJ9ZxMPFHRFS9V3DxQFp7Pn22xIvO9TPP62%2BH0%2FwWFHxqA7XPeiBp0JPjllYR3cRSEemA788S6T93srkbMwd9lIbd7uHf24NdkafVbH0paiPhGrohcaWHNUSK0Dxdi6XOalh5E7ZTSON5%2F%2FuQ0W1uS%2FUx6LzZGQ2sesbPcL57Mxr%2F2hl1%2BPwz%2BF06gtWhGAm%2FsfOD2fM8yhzSntIj7vI8tLsSJXelycfiH%2Fxtm8IsSDmQmpW%2Bfh7NQoxWApZqViwsnzfbYSOZhJL7hMS9t17XofnTw%2BxKk%2BD29NVIgbdW1%2FXwY8dQZezker2%2F1uczlNxSZLWXTUMEGsK0zgvdDaVWd9878HDep7odcaQaCtRpsl159wuV49rxLCDJR%2BShN1EhcmhmMq8yTzeY7mH%2FMWDeMpSSvLeAirUghOuJQTg1tE0S1w1fjB9dZrO%2FZuQWQCc2IYwqKTiqOQvAnxUmqS8vzsSg8FZZjDze%2FkJ552kHhYXyRyPEZD1QULKK7K9WXRAurs9juJDDyE8VS8lnnaDA%2BR6Jjos5p2us2euavy4wDBfNa3mVmnnBaRCo3SfIobxO2QIyQU5SzMTPKPQma7Cn2Z96%2BbpP%2Bapz2RGbAm2y9f0Pk2mOJP5QKttvU4IvfuIun1LMbRnrSw1LMY2TjXtt0lVNP46mNI8sz9Nwy%2BKLItsTnZVdBVmd3duqV7b6YCkOx3HzD3bNT0XI2w%2FGcQgqR4qbJz5dLPSv6E18c%2BbonrNIzj65MLpyTwVAw2eDcLMgtPb8Uh%2FCbMYzsajdGcSlN2Q7PqkYP%2Be%2FogXI1JaweYvML%2BesqQGOpoB73r99iCMzzCsNSpTykTAa4Hd8iQdPzAuY1wyAclSd6z58Wh62UlVYx%2FWCN2O5ndxEl2oN%2FBooeJgtUdWr3%2FjGrgdYKEUG3oNI4wYSASiVFN3YmO5kJnG3ApNpY9hTSE5ioiixutS3oNQFwOze%2FCaADbxwWQu34MtsRt2%2FQV8siqb%2BDvTkuTNwUmYH%2FmR9cheDCF9NZX%2FPvRgNA%3D%3D&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20230616T165512Z&X-Amz-SignedHeaders=host&X-Amz-Expires=30&X-Amz-Credential=ASIASG3IHPL6YLWJYXDT%2F20230616%2Fus-west-2%2Fs3%2Faws4_request&X-Amz-Signature=aa21f39058bc4d3593ffb457161f93e8906040e9feaee2d984a8a0072edab334 [121325129/121325129] -> "boost_1_82_0.tar.bz2" [1]
Error: failed to download boost_1_82_0.tar.bz2: SHA256 mismatch.
https://download.ceph.com/qa/boost_1_82_0.tar.bz2:
2023-06-16 16:55:20 ERROR 404: Not Found.
Download of https://download.ceph.com/qa/boost_1_82_0.tar.bz2 failed
Error: failed to download boost_1_82_0.tar.bz2.

Can you have a look?

@ljflores
Copy link
Member

ljflores commented Jun 16, 2023

Please re-add the "needs-qa" label when this is ready for testing again.

@adamemerson adamemerson force-pushed the wip-boost-the-boost branch from 45f04f4 to 6903465 Compare June 23, 2023 13:04
@adamemerson adamemerson force-pushed the wip-boost-the-boost branch from 6903465 to 8fe1bdc Compare July 5, 2023 19:14
@adamemerson
Copy link
Contributor Author

adamemerson commented Jul 5, 2023

Hey @adamemerson, when we try to start a build for this in Shaman, it fails from https://jenkins.ceph.com/job/ceph-dev-new-setup/71572/console

ceph-18.0.0-4409-gcb52cb90/src/.git_version
ceph-18.0.0-4409-gcb52cb90/ceph.spec
2023-06-16 16:55:19 URL:https://jfrog-prod-usw2-shared-oregon-main.s3.amazonaws.com/aol-boostorg/filestore/5c/5c0736ce8d6f0d21275a1d9407dce48e6decce6a?X-Artifactory-username=anonymous&X-Artifactory-repoType=local&X-Artifactory-repositoryKey=main&X-Artifactory-packageType=generic&X-Artifactory-artifactPath=release%2F1.82.0%2Fsource%2Fboost_1_82_0.tar.bz2&X-Artifactory-projectKey=default&x-jf-traceId=e80827ce537d547f&response-content-disposition=attachment%3Bfilename%3D%22boost_1_82_0.tar.bz2%22&response-content-type=application%2Fx-bzip2&X-Amz-Security-Token=IQoJb3JpZ2luX2VjEPH%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLXdlc3QtMiJHMEUCIQCarxp966I7oP5hCFpWmt6ZJfw15IL%2FN2xnuXzARXF3OAIgWuc4ya3Oa6epbuZP2%2BrrA8YfPe3FXOotroR%2BjUWIYxkqhgUIShAAGgwxNTIxNTMwNjIxNDEiDH%2BBKIX9NjUswGTixCrjBEKOOJ9ZxMPFHRFS9V3DxQFp7Pn22xIvO9TPP62%2BH0%2FwWFHxqA7XPeiBp0JPjllYR3cRSEemA788S6T93srkbMwd9lIbd7uHf24NdkafVbH0paiPhGrohcaWHNUSK0Dxdi6XOalh5E7ZTSON5%2F%2FuQ0W1uS%2FUx6LzZGQ2sesbPcL57Mxr%2F2hl1%2BPwz%2BF06gtWhGAm%2FsfOD2fM8yhzSntIj7vI8tLsSJXelycfiH%2Fxtm8IsSDmQmpW%2Bfh7NQoxWApZqViwsnzfbYSOZhJL7hMS9t17XofnTw%2BxKk%2BD29NVIgbdW1%2FXwY8dQZezker2%2F1uczlNxSZLWXTUMEGsK0zgvdDaVWd9878HDep7odcaQaCtRpsl159wuV49rxLCDJR%2BShN1EhcmhmMq8yTzeY7mH%2FMWDeMpSSvLeAirUghOuJQTg1tE0S1w1fjB9dZrO%2FZuQWQCc2IYwqKTiqOQvAnxUmqS8vzsSg8FZZjDze%2FkJ552kHhYXyRyPEZD1QULKK7K9WXRAurs9juJDDyE8VS8lnnaDA%2BR6Jjos5p2us2euavy4wDBfNa3mVmnnBaRCo3SfIobxO2QIyQU5SzMTPKPQma7Cn2Z96%2BbpP%2Bapz2RGbAm2y9f0Pk2mOJP5QKttvU4IvfuIun1LMbRnrSw1LMY2TjXtt0lVNP46mNI8sz9Nwy%2BKLItsTnZVdBVmd3duqV7b6YCkOx3HzD3bNT0XI2w%2FGcQgqR4qbJz5dLPSv6E18c%2BbonrNIzj65MLpyTwVAw2eDcLMgtPb8Uh%2FCbMYzsajdGcSlN2Q7PqkYP%2Be%2FogXI1JaweYvML%2BesqQGOpoB73r99iCMzzCsNSpTykTAa4Hd8iQdPzAuY1wyAclSd6z58Wh62UlVYx%2FWCN2O5ndxEl2oN%2FBooeJgtUdWr3%2FjGrgdYKEUG3oNI4wYSASiVFN3YmO5kJnG3ApNpY9hTSE5ioiixutS3oNQFwOze%2FCaADbxwWQu34MtsRt2%2FQV8siqb%2BDvTkuTNwUmYH%2FmR9cheDCF9NZX%2FPvRgNA%3D%3D&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20230616T165512Z&X-Amz-SignedHeaders=host&X-Amz-Expires=30&X-Amz-Credential=ASIASG3IHPL6YLWJYXDT%2F20230616%2Fus-west-2%2Fs3%2Faws4_request&X-Amz-Signature=aa21f39058bc4d3593ffb457161f93e8906040e9feaee2d984a8a0072edab334 [121325129/121325129] -> "boost_1_82_0.tar.bz2" [1]
Error: failed to download boost_1_82_0.tar.bz2: SHA256 mismatch.
https://download.ceph.com/qa/boost_1_82_0.tar.bz2:
2023-06-16 16:55:20 ERROR 404: Not Found.
Download of https://download.ceph.com/qa/boost_1_82_0.tar.bz2 failed
Error: failed to download boost_1_82_0.tar.bz2.

Can you have a look?

Thanks, looks like make-dist had its own copy of the SHA. This should be good, now.

@adamemerson
build: Bump boost to 1.82
244c5eb 
Needed to fix coroutine detection under Clang

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
@adamemerson adamemerson force-pushed the wip-boost-the-boost branch from 8fe1bdc to 244c5eb Compare July 5, 2023 19:45
@ljflores
Copy link
Member

ljflores commented Jul 7, 2023

@adamemerson will put in next batch!

@cbodley cbodley mentioned this pull request Jul 10, 2023
Closed
@ljflores
Copy link
Member

ljflores commented Jul 11, 2023

Rados approved: https://tracker.ceph.com/projects/rados/wiki/MAIN#httpstrellocomcBHAY6fGO1801-wip-yuri10-testing-2023-07-10-1345

@yuriw yuriw merged commit 2aaf8db into ceph:main Jul 11, 2023
@petrutlucian94
Copy link
Contributor

petrutlucian94 commented Jul 13, 2023 •
edited
Loading

This broke the Windows job, I first mentioned the issue here: #49737 (comment).

It's an easy fix though, all we have to do is skip patching the boost .py file that was removed from recent Boost versions.

LE: I've submitted a patch: #52427

@cbodley cbodley mentioned this pull request Jul 17, 2023
Closed
4 tasks
@adamemerson adamemerson deleted the wip-boost-the-boost branch November 1, 2023 16:27
@cbodley cbodley mentioned this pull request May 23, 2024
Merged
14 tasks
bazaah added a commit to bazaah/aur-ceph that referenced this pull request Oct 3, 2024
@bazaah
pkgbuild: rm rgw-client-boost-string-view.patch
1fa77f5 
fixed upstream

Upstream-ref: ceph/ceph#51573
bazaah added a commit to bazaah/aur-ceph that referenced this pull request Oct 4, 2024
@bazaah
pkgbuild: rm rgw-client-boost-string-view.patch
2499218 
fixed upstream

Upstream-ref: ceph/ceph#51573
bazaah added a commit to bazaah/aur-ceph that referenced this pull request Feb 6, 2025
@bazaah
pkgbuild: rm rgw-client-boost-string-view.patch
77a87e8 
fixed upstream

Upstream-ref: ceph/ceph#51573
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbodley cbodley cbodley approved these changes

Assignees

No one assigned

Labels

build/ops core needs-qa rgw wip-yuri10-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adamemerson @ljflores @petrutlucian94 @cbodley @yuriw