Skip to content

squid: qa: Add multifs root_squash testcase#56689

Open
kotreshhr wants to merge 3 commits intoceph:squidfrom
kotreshhr:wip-64939-squid
Open

squid: qa: Add multifs root_squash testcase#56689
kotreshhr wants to merge 3 commits intoceph:squidfrom
kotreshhr:wip-64939-squid

Conversation

@kotreshhr
Copy link
Contributor

@kotreshhr kotreshhr commented Apr 4, 2024 •
edited
Loading

backport tracker: https://tracker.ceph.com/issues/64939

backport of #55833
parent tracker: https://tracker.ceph.com/issues/64641

backport tracker: https://tracker.ceph.com/issues/65907

backport of #56846
parent tracker: https://tracker.ceph.com/issues/65246

Bot the trackers need to be backported as the #55833 has a bug.

@kotreshhr kotreshhr added this to the squid milestone Apr 4, 2024
@kotreshhr kotreshhr added the tests label Apr 4, 2024
@github-actions github-actions bot added the cephfs Ceph File System label Apr 4, 2024
@kotreshhr kotreshhr requested a review from a team April 4, 2024 06:38
@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Apr 12, 2024

Marking this as DNM because this test is broken, which wasn't discovered since it wasn't tested with vstart_runner.py or teuthology. A fix has been written for it (#56846). Both of them needs to be backported together to avoid passing same bug to release branches.

@joscollin
Copy link
Member

joscollin commented May 21, 2024

jenkins test make check

@github-actions
Copy link

github-actions bot commented May 23, 2024

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@kotreshhr
Copy link
Contributor Author

kotreshhr commented Jun 21, 2024

Marking this as DNM because this test is broken, which wasn't discovered since it wasn't tested with vstart_runner.py or teuthology. A fix has been written for it (#56846). Both of them needs to be backported together to avoid passing same bug to release branches.

@rishabh-d-dave Would you take care of this ? or should I backport #56846 with this ?

@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Jun 21, 2024

Marking this as DNM because this test is broken, which wasn't discovered since it wasn't tested with vstart_runner.py or teuthology. A fix has been written for it (#56846). Both of them needs to be backported together to avoid passing same bug to release branches.

@rishabh-d-dave Would you take care of this ? or should I backport #56846 with this ?

IIRC, last time checked despite of #56846 this test is not doing fine, I'll re-check.

@joscollin
Copy link
Member

joscollin commented Jun 26, 2024

@kotreshhr Please fix the conflicts

@kotreshhr
Copy link
Contributor Author

kotreshhr commented Aug 1, 2024

@kotreshhr Please fix the conflicts

Done

@kotreshhr
Copy link
Contributor Author

kotreshhr commented Aug 1, 2024

Marking this as DNM because this test is broken, which wasn't discovered since it wasn't tested with vstart_runner.py or teuthology. A fix has been written for it (#56846). Both of them needs to be backported together to avoid passing same bug to release branches.

Fixed it

@kotreshhr kotreshhr removed the DNM label Aug 1, 2024
@lxbsz
Copy link
Member

lxbsz commented Aug 2, 2024

This PR is under test in https://tracker.ceph.com/issues/67316.

rishabh-d-dave
rishabh-d-dave requested changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA run was unsuccessful. From https://pulpito.ceph.com/xiubli-2024-08-05_05:14:48-fs-wip-xiubli-testing-20240802.055215-squid-distro-default-smithi/7836646 -

fail    7836646     0:31:34     fs/functional/{begin/{0-install 1-ceph 2-logrotate 3-modules} clusters/1a3s-mds-4c-client conf/{client mds mgr mon osd} distro/{centos_latest} mount/kclient/{mount-syntax/{v2} mount overrides/{distro/stock/{centos_9.stream k-stock} ms-die-on-skipped}} objectstore/bluestore-ec-root overrides/{ignorelist_health ignorelist_wrongly_marked_down no_client_pidfile pg_health} subvol_versions/create_subvol_version_v2 tasks/admin}    2
Failure Reason:

Test failure: test_multifs_single_path_rootsquash (tasks.cephfs.test_admin.TestFsAuthorize), test_multifs_single_path_rootsquash (tasks.cephfs.test_admin.TestFsAuthorize)

@vshankar
Copy link
Contributor

vshankar commented Nov 6, 2024

QA run was unsuccessful. From https://pulpito.ceph.com/xiubli-2024-08-05_05:14:48-fs-wip-xiubli-testing-20240802.055215-squid-distro-default-smithi/7836646 -

fail    7836646     0:31:34     fs/functional/{begin/{0-install 1-ceph 2-logrotate 3-modules} clusters/1a3s-mds-4c-client conf/{client mds mgr mon osd} distro/{centos_latest} mount/kclient/{mount-syntax/{v2} mount overrides/{distro/stock/{centos_9.stream k-stock} ms-die-on-skipped}} objectstore/bluestore-ec-root overrides/{ignorelist_health ignorelist_wrongly_marked_down no_client_pidfile pg_health} subvol_versions/create_subvol_version_v2 tasks/admin}    2
Failure Reason:

Test failure: test_multifs_single_path_rootsquash (tasks.cephfs.test_admin.TestFsAuthorize), test_multifs_single_path_rootsquash (tasks.cephfs.test_admin.TestFsAuthorize)

@kotreshhr PTAL.

@vshankar
Copy link
Contributor

vshankar commented Jan 3, 2025

QA run was unsuccessful. From https://pulpito.ceph.com/xiubli-2024-08-05_05:14:48-fs-wip-xiubli-testing-20240802.055215-squid-distro-default-smithi/7836646 -

fail    7836646     0:31:34     fs/functional/{begin/{0-install 1-ceph 2-logrotate 3-modules} clusters/1a3s-mds-4c-client conf/{client mds mgr mon osd} distro/{centos_latest} mount/kclient/{mount-syntax/{v2} mount overrides/{distro/stock/{centos_9.stream k-stock} ms-die-on-skipped}} objectstore/bluestore-ec-root overrides/{ignorelist_health ignorelist_wrongly_marked_down no_client_pidfile pg_health} subvol_versions/create_subvol_version_v2 tasks/admin}    2
Failure Reason:

Test failure: test_multifs_single_path_rootsquash (tasks.cephfs.test_admin.TestFsAuthorize), test_multifs_single_path_rootsquash (tasks.cephfs.test_admin.TestFsAuthorize)

@kotreshhr PTAL.

Gentle nudge on this @kotreshhr

@mchangir
Copy link
Contributor

mchangir commented Feb 10, 2025

This PR is under test in https://tracker.ceph.com/issues/69882.

@joscollin
Copy link
Member

joscollin commented Oct 7, 2025

kotreshhr:wip-64939-squid is rebased by #65802 and it is under testing.

kotreshhr and others added 3 commits March 18, 2026 10:22
@kotreshhr @batrick
qa: Add multifs root_squash testcase
49942ee 
Fixes: https://tracker.ceph.com/issues/64641
Signed-off-by: Kotresh HR <khiremat@redhat.com>
(cherry picked from commit 1fda8ed)

Conflicts:
  qa/tasks/cephfs/test_admin.py - Few of the other tests got added
in between.
@rishabh-d-dave @batrick
qa/cephfs: run test_multifs_single_path_rootsquash for kclient too
50f8807 
Root squash is valid for kclient too, Kotresh ran test recently fo it
against main branch. Therefore it is safe to remove.
ceph#56846 (comment)

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 422d98c)
@rishabh-d-dave @batrick
qa/cephfs: fix test_multifs_single_path_rootsquash
54d3791 
test_multifs_single_path_rootsquash was never run with vstart_runner.py
or with teuthology and is therefore full of bugs. Fix it to make sure it
runs fine.

Introduced-by: 1fda8ed
Fixes: https://tracker.ceph.com/issues/65246
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit d9752a6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rishabh-d-dave rishabh-d-dave rishabh-d-dave requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

cephfs Ceph File System tests

Projects

None yet

Milestone

squid

Development

Successfully merging this pull request may close these issues.

6 participants

@kotreshhr @rishabh-d-dave @joscollin @lxbsz @vshankar @mchangir