Skip to content

squid: mds: ensure snapclient is synced before corruption check#56397

Merged
batrick merged 1 commit intoceph:squidfrom
batrick:wip-64920-squid
Mar 25, 2024
Merged

squid: mds: ensure snapclient is synced before corruption check#56397
batrick merged 1 commit intoceph:squidfrom
batrick:wip-64920-squid

Conversation

@batrick
Copy link
Member

@batrick batrick commented Mar 22, 2024

backport tracker: https://tracker.ceph.com/issues/64920


backport of #55412
parent tracker: https://tracker.ceph.com/issues/64058

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

During resolve, orphan dirfrags are purged which may result in dentry commits.
If the snapclient is not sync'd (which normally happens as the last step of
up:resolve), then the snapclient indicates the last sequence is 1 which is
always less than a dentry's legitimate "first" value.

Fixes: https://tracker.ceph.com/issues/64058
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit caa34c1)
@batrick batrick added this to the squid milestone Mar 22, 2024
batrick added a commit to batrick/ceph that referenced this pull request Mar 22, 2024
* refs/pull/56397/head:
	mds: ensure snapclient is synced before corruption check
batrick added a commit to batrick/ceph that referenced this pull request Mar 23, 2024
* refs/pull/56397/head:
	mds: ensure snapclient is synced before corruption check
@batrick
Copy link
Member Author

batrick commented Mar 25, 2024

@leonid-s-usov leonid-s-usov requested a review from a team March 25, 2024 17:50
@batrick batrick merged commit 5242428 into ceph:squid Mar 25, 2024
@batrick batrick deleted the wip-64920-squid branch March 25, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants