Skip to content

mds: ensure snapclient is synced before corruption check#55412

Merged
vshankar merged 1 commit intoceph:mainfrom
batrick:i64290
Mar 14, 2024
Merged

mds: ensure snapclient is synced before corruption check#55412
vshankar merged 1 commit intoceph:mainfrom
batrick:i64290

Conversation

@batrick
Copy link
Member

@batrick batrick commented Feb 1, 2024

Fixes: https://tracker.ceph.com/issues/64058

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@batrick
Copy link
Member Author

batrick commented Feb 1, 2024

I thought there was an outstanding ticket for this (as I've seen it before) but I cannot locate it.

@batrick batrick requested a review from vshankar February 1, 2024 14:56
@vshankar
Copy link
Contributor

vshankar commented Feb 8, 2024

@batrick Could you explain a bit more about why this warning shows up due to snap client not synchorized with snap server? (and also include it in the commit message)

During resolve, orphan dirfrags are purged which may result in dentry commits.
If the snapclient is not sync'd (which normally happens as the last step of
up:resolve), then the snapclient indicates the last sequence is 1 which is
always less than a dentry's legitimate "first" value.

Fixes: https://tracker.ceph.com/issues/64058
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
@batrick
Copy link
Member Author

batrick commented Feb 28, 2024

@batrick Could you explain a bit more about why this warning shows up due to snap client not synchorized with snap server? (and also include it in the commit message)

Please see the commit message and https://tracker.ceph.com/issues/64058#note-2

@vshankar
Copy link
Contributor

@batrick Could you explain a bit more about why this warning shows up due to snap client not synchorized with snap server? (and also include it in the commit message)

Please see the commit message and https://tracker.ceph.com/issues/64058#note-2

Makes more sense now that the context is set :)

@vshankar
Copy link
Contributor

Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants