mon: do not log MON_DOWN if monitor uptime is less than threshold#56271
Merged
mon: do not log MON_DOWN if monitor uptime is less than threshold#56271
Conversation
batrick
added a commit
to batrick/ceph
that referenced
this pull request
Mar 18, 2024
* refs/pull/56271/head: mon: do not log MON_DOWN if monitor uptime is less than threshold
Member
Author
|
This is largely prompted from fallout created by #55455. |
Member
Author
|
jenkins test api |
Fixes: https://tracker.ceph.com/issues/64968 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Fixes: https://tracker.ceph.com/issues/64968 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
This should hopefully no longer be necessary with the addition of mon_down_uptime_grace. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
leonid-s-usov
approved these changes
Mar 19, 2024
Contributor
leonid-s-usov
left a comment
There was a problem hiding this comment.
Nitpicks only, the change is reasonable
Member
Author
vshankar
reviewed
Mar 21, 2024
| - but it is still running | ||
| # MDS daemon 'b' is not responding, replacing it as rank 0 with standby 'a' | ||
| - is not responding | ||
| - MON_DOWN |
Contributor
There was a problem hiding this comment.
+1 for this esp since the monitors can also emit warning with "mons down"
vshankar
approved these changes
Mar 22, 2024
Contributor
vshankar
left a comment
There was a problem hiding this comment.
LGTM. @leonid-s-usov left a suggestion here - https://github.com/ceph/ceph/pull/56271/files#r1530688904
Member
Author
|
I want to include this in the squid series I'm doing and since Leonid has already approved I will merge. |
This was referenced Mar 22, 2024
batrick
added a commit
to batrick/ceph
that referenced
this pull request
Mar 25, 2024
* refs/pull/56271/head: qa/cephfs: stop ignoring MON_DOWN globally qa: extend mon timeout coming up after mondb creation qa: update dashboard schema for mon_status mon: do not log MON_DOWN if monitor uptime is less than threshold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/64968
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e