common/LogEntry: Add log level to str helper for fmt::formatter<LogEntry>#55455
common/LogEntry: Add log level to str helper for fmt::formatter<LogEntry>#55455
Conversation
|
Looks OK, apart from one question: aren't there scripts in Teuthology that grep for WRN in the logs? -- update: as explained to me in the conf call - that's not a bug, but the desired result. |
49b0aa5 to
9d7446c
Compare
…try> The Ceph cluster logs were missing the string equivalent [INF|WRN|ERR|DBG] representation of the 'prio' field. This was broken since the introduction of commit 2901943 of PR: ceph#47830. This probably caused false positives in teuthology testing and particularly for those tests that check for cluster badness by parsing the cluster logs. The fix involves adding a static helper function to the LogEntry struct. This function returns the string appropriate representation of the log level similar to the operator<<() for LogEntry. Fixes: https://tracker.ceph.com/issues/64314 Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
9d7446c to
0bd01b9
Compare
|
jenkins test api |
|
@sseshasa do you also want this in one of Yuri's batches? |
|
Noted. It'll go in the next main batch along with the other PRs you linked. |
|
Teuthology test result There are no related failures. For the full report please see: https://tracker.ceph.com/projects/rados/wiki/MAIN#httpstrellocomcQFtoIRXE1971-wip-yuri4-testing-2024-03-05-0854 This is RADOS approved. |
|
Sorry to comment on a merged PR, but this change should have been run through fs suite @sseshasa. We probably have test case fallouts due to this. See - https://tracker.ceph.com/issues/65020 |
Yes, that was a miss. As suspected, the rados suite run did result in the creation of multiple new trackers due to this PR. Please see https://tracker.ceph.com/projects/rados/wiki/MAIN#httpstrellocomcQFtoIRXE1971-wip-yuri4-testing-2024-03-05-0854 for a list of new trackers raised. I suspect there could be common failures between rados and cephfs suites and those trackers can be used to track the fixes to alleviate the task a bit. For failures unique to fs suite, new trackers can be raised. |
The Ceph cluster logs were missing the string equivalent [INF|WRN|ERR|DBG] representation of the 'prio' field. This was broken since the introduction of commit 2901943 of PR: #47830. This probably caused false positives in teuthology testing and particularly for those tests that check for cluster badness by parsing the cluster logs.
The fix involves adding a static helper function to the LogEntry struct. This function returns the string appropriate representation of the log level similar to the operator<<() for LogEntry.
Signed-off-by: Sridhar Seshasayee sseshasa@redhat.com
Fixes: https://tracker.ceph.com/issues/64314
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e