quincy: osd/PeeringState: fix missed recheck_readable from laggy#49304
Merged
yuriw merged 1 commit intoceph:quincyfrom Jun 5, 2023
Merged
quincy: osd/PeeringState: fix missed recheck_readable from laggy#49304yuriw merged 1 commit intoceph:quincyfrom
recheck_readable from laggy#49304yuriw merged 1 commit intoceph:quincyfrom
Conversation
Previously, the first `pg_lease_ack_t` after becoming laggy would not trigger `recheck_readable`. However, every other ack would trigger it. The logic is inverted, causing unnecessarily long laggy PG state. Fixes: 3bb8a72 (osd: requeue ops when PG is no longer laggy) Fixes: https://tracker.ceph.com/issues/53806 Signed-off-by: 胡玮文 <huww98@outlook.com> (cherry picked from commit caeca39)
neha-ojha
approved these changes
Dec 7, 2022
recheck_readable from laggyrecheck_readable from laggy
rzarzynski
added a commit
to rzarzynski/ceph
that referenced
this pull request
Dec 21, 2022
This reverts commit 9337fa6. It's a `main`'s counterpart of quincy's PRs ceph#47901 and ceph#49304. Fixes: https://tracker.ceph.com/issues/57546 Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
rzarzynski
added a commit
to rzarzynski/ceph
that referenced
this pull request
Dec 21, 2022
This reverts commit 9337fa6. It's a `main`'s counterpart of quincy's PRs ceph#48104 and ceph#49304. Fixes: https://tracker.ceph.com/issues/57546 Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
14 tasks
Member
|
@rzarzynski does this need qa? |
Contributor
Author
|
@ljflores: I think so. Just added the label. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the first
pg_lease_ack_tafter becoming laggy would not triggerrecheck_readable. However, every other ack would trigger it. The logic is inverted, causing unnecessarily long laggy PG state.Fixes: 3bb8a72 (osd: requeue ops when PG is no longer laggy) Fixes: https://tracker.ceph.com/issues/53806
Signed-off-by: 胡玮文 huww98@outlook.com
(cherry picked from commit caeca39)
This PR is minimized version of #47901 which got reverted in #48104. It looks the failures were caused by the first, not essential commit (see https://tracker.ceph.com/issues/57546#note-9), so let's try the essential one alone.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows