quincy: osd/PeeringState: fix missed recheck_readable from laggy#47901
Merged
yuriw merged 2 commits intoceph:quincyfrom Sep 7, 2022
Merged
quincy: osd/PeeringState: fix missed recheck_readable from laggy#47901yuriw merged 2 commits intoceph:quincyfrom
yuriw merged 2 commits intoceph:quincyfrom
Conversation
We should not have duplicated OSD ID in `acting`. So the loop would execute once anyway. Signed-off-by: 胡玮文 <huww98@outlook.com> (cherry picked from commit 9337fa6)
Previously, the first `pg_lease_ack_t` after becoming laggy would not trigger `recheck_readable`. However, every other ack would trigger it. The logic is inverted, causing unnecessarily long laggy PG state. Fixes: 3bb8a72 (osd: requeue ops when PG is no longer laggy) Fixes: https://tracker.ceph.com/issues/53806 Signed-off-by: 胡玮文 <huww98@outlook.com> (cherry picked from commit caeca39)
neha-ojha
approved these changes
Sep 1, 2022
neha-ojha
approved these changes
Sep 1, 2022
Contributor
|
Contributor
|
jenkins test make check |
Contributor
|
Unrelated failure:
Tracked by: |
ljflores
added a commit
that referenced
this pull request
Sep 29, 2022
This PR was reverted. Signed-off-by: Laura Flores <lflores@redhat.com>
14 tasks
rzarzynski
added a commit
to rzarzynski/ceph
that referenced
this pull request
Dec 21, 2022
This reverts commit 9337fa6. It's a `main`'s counterpart of quincy's PRs ceph#47901 and ceph#49304. Fixes: https://tracker.ceph.com/issues/57546 Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/56736
backport of #44499
parent tracker: https://tracker.ceph.com/issues/53806
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh