Skip to content

os/bluestore: get rid of fake onode nref increment for pinned entry#44311

Merged
yuriw merged 1 commit intoceph:masterfrom
ifed01:wip-ifed-cleanup-onode-pin
Dec 24, 2021
Merged

os/bluestore: get rid of fake onode nref increment for pinned entry#44311
yuriw merged 1 commit intoceph:masterfrom
ifed01:wip-ifed-cleanup-onode-pin

Conversation

@ifed01
Copy link
Contributor

@ifed01 ifed01 commented Dec 14, 2021 •
edited
Loading

A follow-up of #43770, sitting on top of it.

Signed-off-by: Igor Fedotov igor.fedotov@croit.io

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@ifed01 ifed01 requested a review from aclamk December 14, 2021 15:01
@github-actions github-actions bot added the core label Dec 14, 2021
@ifed01 ifed01 mentioned this pull request Dec 14, 2021
Merged
3 tasks
@ifed01 ifed01 force-pushed the wip-ifed-cleanup-onode-pin branch from db29c7d to 2ce7968 Compare December 14, 2021 23:22
@ifed01 ifed01 changed the title RFC,DNM: os/bluestore: get rid of fake onode nref increment for pinned entry os/bluestore: get rid of fake onode nref increment for pinned entry Dec 15, 2021
@aclamk
Copy link
Contributor

aclamk commented Dec 17, 2021

Awesome!
I was somehow pretty sure that this modification will make possible to create race condition letting us leave in incoherent pinned=true and nref=1 state.
I cannot find such scenario now.
I am happy that I was wrong.

@aclamk aclamk mentioned this pull request Dec 17, 2021
Closed
14 tasks
@ifed01
os/bluestore: get rid of fake onode nref increment for pinned entry
0960f98 
Looks like this isn't necessary any more after fixing
https://tracker.ceph.com/issues/53002

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
@ifed01 ifed01 force-pushed the wip-ifed-cleanup-onode-pin branch from 2ce7968 to 0960f98 Compare December 20, 2021 12:15
@ifed01 ifed01 requested a review from aclamk December 20, 2021 12:16
@markhpc
Copy link
Member

markhpc commented Dec 23, 2021

Adding the performance label as this touches fairly performance sensitive code (even if we don't expect it to affect performance).

@yuriw
Copy link
Contributor

yuriw commented Dec 23, 2021

jenkins test api

@yuriw
Copy link
Contributor

yuriw commented Dec 23, 2021

unrelated failures

Bug #53723: Cephadm agent fails to report and causes a health timeout - Orchestrator - Ceph
Bug #53499: test_dashboard_e2e.sh Failure: orchestrator/02-hosts-inventory.e2e failed. - Dashboard - Ceph
Bug #53424: CEPHADM_DAEMON_PLACE_FAIL in orch:cephadm/mgr-nfs-upgrade/ - Orchestrator - Ceph
Bug #53680: ERROR:tasks.rook:'waiting for service removal' reached maximum tries (90) after waiting for 900 seconds - Orchestrator - Ceph

@yuriw yuriw merged commit 7659877 into ceph:master Dec 24, 2021
@ifed01 ifed01 deleted the wip-ifed-cleanup-onode-pin branch December 24, 2021 00:48
@taodd taodd mentioned this pull request Oct 20, 2022
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aclamk aclamk aclamk approved these changes

Assignees

No one assigned

Labels

bluestore cleanup core needs-qa performance wip-yuri10-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ifed01 @aclamk @markhpc @yuriw