rgw/keystone: EC2Engine uses reject() for ERR_SIGNATURE_NO_MATCH#53680
rgw/keystone: EC2Engine uses reject() for ERR_SIGNATURE_NO_MATCH#53680
Conversation
ERR_SIGNATURE_NO_MATCH means that we found the given access key in keystone, so we should use reject() instead of deny() to prevent other engines like LocalEngine from looking up the access key again this change causes us to return the SignatureDoesNotMatch error expected by s3test case test_list_buckets_bad_auth() Fixes: https://tracker.ceph.com/issues/62989 Signed-off-by: Casey Bodley <cbodley@redhat.com>
|
discovered this while testing #52813 |
|
jenkins test api |
|
oops! i didn't test this against keystone ec2 until now, and the test case is still failing:
that error message shows that i'll open another pr to fix the error handling here. but several other users of |
|
^ followup in #53846 |
ERR_SIGNATURE_NO_MATCHmeans that we found the given access key in keystone, so we should usereject()instead ofdeny()to prevent other engines likeLocalEnginefrom looking up the access key againthis change causes us to return the
SignatureDoesNotMatcherror expected by s3test casetest_list_buckets_bad_auth()Fixes: https://tracker.ceph.com/issues/62989
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows