rgw: fix http error checks in keystone/barbican/vault clients#53846
Merged
rgw: fix http error checks in keystone/barbican/vault clients#53846
Conversation
when RGWHTTPManager encounters an http error, it uses rgw_http_error_to_errno() to map that to a negative posix error code. RGWHTTPClient::process() returns that mapped error code, and exposes the original http error via get_http_status() the http client code for keystone, barbican, and vault were returning early on the errors from process(), so weren't getting to the http error checks these clients now check for specific http errors before testing the result of process() Fixes: https://tracker.ceph.com/issues/62989 Signed-off-by: Casey Bodley <cbodley@redhat.com>
Contributor
Author
|
passed qa in https://pulpito.ceph.com/cbodley-2023-10-06_14:43:00-rgw-wip-62989-again-distro-default-smithi/ including the s3test-against-keystone-ec2 job that was failing before:
|
dang
approved these changes
Oct 11, 2023
tobias-urdin
added a commit
to tobias-urdin/ceph
that referenced
this pull request
Jan 18, 2024
This changes so that we don't return before even checking if the request failed by checking the response code like was done for other methods in [1]. [1] ceph#53846 Signed-off-by: Tobias Urdin <tobias.urdin@binero.se>
14 tasks
AliMasarweh
pushed a commit
to AliMasarweh/ceph
that referenced
this pull request
Feb 13, 2024
This changes so that we don't return before even checking if the request failed by checking the response code like was done for other methods in [1]. [1] ceph#53846 Signed-off-by: Tobias Urdin <tobias.urdin@binero.se>
AliMasarweh
pushed a commit
to AliMasarweh/ceph
that referenced
this pull request
Feb 19, 2024
This changes so that we don't return before even checking if the request failed by checking the response code like was done for other methods in [1]. [1] ceph#53846 Signed-off-by: Tobias Urdin <tobias.urdin@binero.se>
AliMasarweh
pushed a commit
to AliMasarweh/ceph
that referenced
this pull request
Feb 20, 2024
This changes so that we don't return before even checking if the request failed by checking the response code like was done for other methods in [1]. [1] ceph#53846 Signed-off-by: Tobias Urdin <tobias.urdin@binero.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when
RGWHTTPManagerencounters an http error, it usesrgw_http_error_to_errno()to map that to a negative posix error code.RGWHTTPClient::process()returns that mapped error code, and exposes the original http error viaget_http_status()the http client code for keystone, barbican, and vault were returning early on the errors from
process(), so weren't getting to the http error checksthese clients now check for specific http errors before testing the result of
process()Fixes: https://tracker.ceph.com/issues/62989
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows