tasks: Add crimson collection mark for later use in the database#53424
tasks: Add crimson collection mark for later use in the database#53424NitzanMordhai wants to merge 1 commit intoceph:mainfrom
Conversation
|
jenkins test windows |
4e5aace to
8b93b20
Compare
| branch = ctx.config.get('branch', None) | ||
|
|
||
| return f'{server}:{grafana_port}/d/{Dash_id}?orgId=1&var-branch_name={branch}&var-job_id_selected={job_id}' | ||
| return f'{server}:{grafana_port}/d/{Dash_id}?orgId=1&var-branch_name={branch}&var-job_id_selected1={job_id}' |
There was a problem hiding this comment.
accidental change?
LGTM otherwise!
nit: Commit title qa/tasks/cbt_performance:
There was a problem hiding this comment.
Did you rename job_id_selected to job_id_selected1 on purpose?
There was a problem hiding this comment.
Did you rename
job_id_selectedtojob_id_selected1on purpose?
Yes, we will have in Grafana link 2 job_ids job_id_selected1\job_id_selected2 for comparing, the first one will be picked by the current job id that run
8b93b20 to
0e310bf
Compare
|
@rzarzynski can we merge it? |
rzarzynski
left a comment
There was a problem hiding this comment.
Let's have a standard qa run. However, the probability of failure seems very low, so this PR can be glued to virtually any testing branch.
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
…n the database Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
0e310bf to
7dab721
Compare
|
i ran all the crimson perf options: https://pulpito.ceph.com/nmordech-2024-10-31_05:12:12-crimson-rados:perf-main-distro-default-smithi/ @yuriw can you add it to one of the next tests? |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
lee-j-sanders
left a comment
There was a problem hiding this comment.
This is unrelated to any of the CBT work Chris and I are doing. This is the teuthology side usage of CBT so won't affect us, thanks for checking.. Changes look good to me.
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
To identify crimson run, I added new boolean field in the database to let the Grafana views to filter crimson performance runs
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows