mds: trim cache regularly for standby-replay#40486
Merged
batrick merged 2 commits intoceph:masterfrom Apr 8, 2021
Merged
Conversation
6396e96 to
a945154
Compare
Member
Author
|
jenkins test api |
sidharthanup
reviewed
Apr 6, 2021
We now regularly do this unconditionally in the MDS, see the upkeep thread. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
This change is slightly awkward because standby-replay MDS do not do all the kinds of upkeep a normal active MDS does. In particular, it is not going to recall client state from clients. This diff also merges the extra recall_client_state in MDCache::check_memory_usage into its only caller (the upkeep thread) where it was also doing a recall. That's just a matter of merging the recall flags. This has the added benefit of making MDCache::check_memory_usage callable for all MDS daemons regardless of state. Fixes: https://tracker.ceph.com/issues/50048 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Member
Author
|
rebased |
sidharthanup
reviewed
Apr 6, 2021
Member
Author
a bug in standby-replay is cluttering the results -- I'll rerun with the fix. |
batrick
added a commit
to batrick/ceph
that referenced
this pull request
Apr 8, 2021
* refs/pull/40486/head: mds: trim cache regularly for standby-replay mds: remove extra heap release
Member
Author
|
https://pulpito.ceph.com/pdonnell-2021-04-08_04:31:36-fs-wip-pdonnell-testing-20210408.024225-distro-basic-smithi/
|
This was referenced Apr 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox