Skip to content

mgr/dashboard: disable NFSv3 support #40154

Closed
epuertat wants to merge 1 commit intoceph:masterfrom
rhcs-dashboard:fix-49718-master
Closed

mgr/dashboard: disable NFSv3 support #40154
epuertat wants to merge 1 commit intoceph:masterfrom
rhcs-dashboard:fix-49718-master

Conversation

@epuertat
Copy link
Member

@epuertat epuertat commented Mar 16, 2021 •
edited
Loading

Rather than removing lots of code supporting v3 NFS exports, I'm just
disabling the NFSv3 selector, so new exports cannot be set to NFSv3. For
the existing ones, this cannot be modified either.

image

Fixes: https://tracker.ceph.com/issues/49718
Signed-off-by: Ernesto Puerta epuertat@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@epuertat
mgr/dashboard: disable NFSv3 support
7fc1e31 
Rather than removing lots of code supporting v3 NFS exports, I'm just
disabling the NFSv3 selector, so new exports cannot be set to NFSv3. For
the existing ones, this cannot be modified either.

Fixes: https://tracker.ceph.com/issues/49718
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
@epuertat epuertat requested a review from a team as a code owner March 16, 2021 15:13
@epuertat epuertat requested review from avanthakkar, callithea and nizamial09 and removed request for a team March 16, 2021 15:13
@epuertat epuertat changed the title mgr/dashboard: disable NFSv3 support mgr/dashboard: disable NFSv3 support Mar 16, 2021
@epuertat
Copy link
Member Author

epuertat commented Mar 16, 2021

jenkins test dashboard

@epuertat
Copy link
Member Author

epuertat commented Mar 16, 2021

jenkins test make check

@epuertat
Copy link
Member Author

epuertat commented Mar 16, 2021

jenkins test dashboard

@kalebskeithley
Copy link
Contributor

kalebskeithley commented Mar 16, 2021 •
edited
Loading

Has this been consulted with the PM downstream? I'm not sure this is OK - have we verified customers are not using it?
(As an example, when we think about migration from RHGS - Gluster's internal NFS implementation was a v3 only).

If we have customers running legacy systems using ceph storage via NFS — e.g. Solaris, HP/UX, or AIX — they may need NFSv3 for some time. (The latest versions of Solaris, HP/UX, and AIX all support NFSv4, but customers may not necessarily be running the latest version.)

A change like this needs lots of advance warning IMO.

Ganesha supports NFSv3 and NFSv4.x. What is the rationale for disabling it in mgr?

@tchaikov
Copy link
Contributor

tchaikov commented Mar 25, 2021

jenkins test make check

@epuertat
Copy link
Member Author

epuertat commented Mar 25, 2021

Closing as this will be undertaken as part of the NFSv4 fixing: https://tracker.ceph.com/issues/49925

@epuertat epuertat closed this Mar 25, 2021
@epuertat epuertat deleted the fix-49718-master branch March 25, 2021 18:47
@votdev
Copy link
Member

votdev commented Apr 29, 2021

Closing as this will be undertaken as part of the NFSv4 fixing: tracker.ceph.com/issues/49925

Are there any plans to backport all these changes mentioned in https://tracker.ceph.com/issues/49925 to Octopus? If not, i would suggest to reopen this PR and backport it to Pacific and Octopus.

NFSv3 is not supported in Octopus according to:

votdev added a commit to votdev/ceph that referenced this pull request Apr 29, 2021
@votdev
mgr/dashboard: remove NFSv3 support from dashboard
3e397f5 
Fixes: https://tracker.ceph.com/issues/49718
Related to: ceph#40154

Signed-off-by: Volker Theile <vtheile@suse.com>
@votdev votdev mentioned this pull request Apr 29, 2021
Merged
3 tasks
votdev added a commit to votdev/ceph that referenced this pull request Apr 29, 2021
@votdev
mgr/dashboard: remove NFSv3 support from dashboard
cff3bdc 
Fixes: https://tracker.ceph.com/issues/49718
Related to: ceph#40154

Signed-off-by: Volker Theile <vtheile@suse.com>
votdev added a commit to votdev/ceph that referenced this pull request Apr 29, 2021
@votdev
mgr/dashboard: remove NFSv3 support from dashboard
8d83180 
Fixes: https://tracker.ceph.com/issues/49718
Related to: ceph#40154

Signed-off-by: Volker Theile <vtheile@suse.com>
votdev added a commit to votdev/ceph that referenced this pull request May 3, 2021
@votdev
mgr/dashboard: disable NFSv3 support in dashboard
864a362 
Fixes: https://tracker.ceph.com/issues/49718
Related to: ceph#40154

Signed-off-by: Volker Theile <vtheile@suse.com>
votdev added a commit to votdev/ceph that referenced this pull request May 6, 2021
@votdev
mgr/dashboard: disable NFSv3 support in dashboard
094a11d 
Fixes: https://tracker.ceph.com/issues/49718
Related to: ceph#40154

Signed-off-by: Volker Theile <vtheile@suse.com>
(cherry picked from commit 864a362)
votdev added a commit to votdev/ceph that referenced this pull request May 6, 2021
@votdev
mgr/dashboard: disable NFSv3 support in dashboard
4746e00 
Fixes: https://tracker.ceph.com/issues/49718
Related to: ceph#40154

Signed-off-by: Volker Theile <vtheile@suse.com>
(cherry picked from commit 864a362)
votdev added a commit to votdev/ceph that referenced this pull request May 17, 2021
@votdev
mgr/dashboard: disable NFSv3 support in dashboard
238f81f 
Fixes: https://tracker.ceph.com/issues/49718
Related to: ceph#40154

Signed-off-by: Volker Theile <vtheile@suse.com>
(cherry picked from commit 864a362)
jtlayton pushed a commit that referenced this pull request Sep 23, 2021
@votdev @epuertat
mgr/dashboard: disable NFSv3 support in dashboard
06836d9 
Fixes: https://tracker.ceph.com/issues/49718
Related to: #40154

Signed-off-by: Volker Theile <vtheile@suse.com>
(cherry picked from commit 864a362)
(cherry picked from commit 238f81f)

Resolves: rhbz#1975788
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avanthakkar avanthakkar Awaiting requested review from avanthakkar

@callithea callithea Awaiting requested review from callithea

@nizamial09 nizamial09 Awaiting requested review from nizamial09

Assignees

No one assigned

Labels

dashboard pybind

Projects

Ceph-Dashboard
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@epuertat @kalebskeithley @tchaikov @votdev