cephadm: Allow to use paths in all <_devices> drivegroup sections#39415
Merged
sebastian-philipp merged 1 commit intoceph:masterfrom Feb 24, 2021
Merged
cephadm: Allow to use paths in all <_devices> drivegroup sections#39415sebastian-philipp merged 1 commit intoceph:masterfrom
sebastian-philipp merged 1 commit intoceph:masterfrom
Conversation
sebastian-philipp
suggested changes
Feb 11, 2021
Contributor
sebastian-philipp
left a comment
There was a problem hiding this comment.
lgtm, some pytest integration would be great here
Contributor
|
conflicts with #39415 but I think your PR is better. I'll rebase |
Member
Author
It conflicts with itself? |
Contributor
This will allow to use specific device paths in any osd component. Signed-off-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
5ce2c25 to
d02683e
Compare
3 tasks
sebastian-philipp
approved these changes
Feb 24, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow to use specific device paths for OSD non collocated
Fixes: https://tracker.ceph.com/issues/49191
Fixes: https://tracker.ceph.com/issues/46558
Signed-off-by: Juan Miguel Olmo Martínez jolmomar@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox