python-common: Verify data_devices is not None#39410
Merged
sebastian-philipp merged 2 commits intoceph:masterfrom Mar 12, 2021
Merged
python-common: Verify data_devices is not None#39410sebastian-philipp merged 2 commits intoceph:masterfrom
sebastian-philipp merged 2 commits intoceph:masterfrom
Conversation
1 task
This comment has been minimized.
This comment has been minimized.
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
Add validation to verify that `data_devices` is not None Fixes: https://tracker.ceph.com/issues/49191 Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
Fixes: https://tracker.ceph.com/issues/48325 Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
a8f3101 to
518edfa
Compare
Contributor
Author
|
Lots of errors:
|
jmolmo
approved these changes
Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validation to verify that
data_devicesis not NoneFixes: https://tracker.ceph.com/issues/49191
Fixes: https://tracker.ceph.com/issues/48325
Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox