Skip to content

nautilus: mgr/progress: introduce turn off/on feature#38173

Merged
yuriw merged 1 commit intoceph:nautilusfrom
kamoltat:wip-ksirivad-nautilus-backports2
Nov 21, 2020
Merged

nautilus: mgr/progress: introduce turn off/on feature#38173
yuriw merged 1 commit intoceph:nautilusfrom
kamoltat:wip-ksirivad-nautilus-backports2

Conversation

@kamoltat
Copy link
Member

@kamoltat kamoltat commented Nov 18, 2020 •
edited
Loading

Progress module can be turned off/on by using
the commands: 'progress off' and 'progress on'

back porting the relevant commits from master PRs:

#37488

Fixes: https://tracker.ceph.com/issues/48265

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@kamoltat kamoltat added this to the nautilus milestone Nov 18, 2020
@kamoltat kamoltat requested a review from neha-ojha November 18, 2020 17:47
neha-ojha
neha-ojha reviewed Nov 18, 2020
View reviewed changes
Copy link
Member

@neha-ojha neha-ojha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamoltat I am sure there were conflicts, please do not remove the "Conflicts:" section from the commit.

@kamoltat kamoltat force-pushed the wip-ksirivad-nautilus-backports2 branch from 8c17894 to 249a3fb Compare November 18, 2020 18:09
neha-ojha
neha-ojha reviewed Nov 18, 2020
View reviewed changes
@kamoltat kamoltat force-pushed the wip-ksirivad-nautilus-backports2 branch 2 times, most recently from 0a23b9e to a9613e8 Compare November 19, 2020 08:30
neha-ojha
neha-ojha reviewed Nov 19, 2020
View reviewed changes
@kamoltat
mgr/progress: introduce turn off/on feature
c847a2f 
progress module can be turned off/on by using
the commands: 'progress off' and 'progress on'

As well as refractoring teuthology test suite
to prevent future bugs that can possibly occur

fixes: https://tracker.ceph.com/issues/47238

Signed-off-by: kamoltat <ksirivad@redhat.com>
(cherry picked from commit 993bb02)

 Conflicts:
	PendingReleaseNotes - add release notes about this feature
	qa/tasks/mgr/test_progress.py - replace helper functions that is neeeded
					for dealing with more than 1 type of events
				      - remove `period` in wait_until_equal()
	src/pybind/mgr/progress/module.py - remove code that deals with mypy in master
	qa/suites/rados/singleton/all/pg-autoscaler-progress-off.yaml - remove log-ignorelist

update some files

Signed-off-by: kamoltat <ksirivad@redhat.com>
@kamoltat kamoltat force-pushed the wip-ksirivad-nautilus-backports2 branch from a9613e8 to c847a2f Compare November 20, 2020 06:53
@yuriw yuriw merged commit a9f19fb into ceph:nautilus Nov 21, 2020
@smithfarm smithfarm changed the title nautilus:mgr/progress: introduce turn off/on feature nautilus: mgr/progress: introduce turn off/on feature Nov 23, 2020
@neha-ojha neha-ojha mentioned this pull request Dec 3, 2020
Closed
kamoltat added a commit to kamoltat/ceph that referenced this pull request Mar 18, 2021
@kamoltat
octopus: delete calling of _osd_in_out_completed_events_count()
ab6e76a 
delete the part where  _osd_in_out_completed_events_count()
was called in test_osd_cannot_recover() and revert to initial
state of the function since we don't need to use this function
in octopus. Also delete a duplicate of _osd_in_out_events_count().
This must be added by mistake in ceph#39289 as well.

No need to fix for the backport in Nautilus: ceph#38173
since the bugs are occured by adding additional code to
the cherry-pick specifically for Octopus.

fixes: https://tracker.ceph.com/issues/49891

Signed-off-by: Kamoltat <ksirivad@redhat.com>
@kamoltat kamoltat mentioned this pull request Mar 18, 2021
Merged
3 tasks
kamoltat added a commit to kamoltat/ceph that referenced this pull request Mar 18, 2021
@kamoltat
qa/tasks/mgr/test_progress.py remove _osd_in_out_completed_events_cou…
e93291a 
…nt()

delete the part where  _osd_in_out_completed_events_count()
was called in test_osd_cannot_recover() and revert to initial
state of the function since we don't need to use this function
in octopus. Also delete a duplicate of _osd_in_out_events_count().
This must be added by mistake in ceph#39289 as well.

No need to fix for the backport in Nautilus: ceph#38173
since the bugs are occured by adding additional code to
the cherry-pick specifically for Octopus.

fixes: https://tracker.ceph.com/issues/49891

Signed-off-by: Kamoltat <ksirivad@redhat.com>
kamoltat added a commit to kamoltat/ceph that referenced this pull request Mar 18, 2021
@kamoltat
qa/tasks/mgr/test_progress.py: remove _osd_in_out_completed_events_co…
b81919d 
…unt()

delete the part where  _osd_in_out_completed_events_count()
was called in test_osd_cannot_recover() and revert to initial
state of the function since we don't need to use this function
in octopus. Also delete a duplicate of _osd_in_out_events_count().
This must be added by mistake in ceph#39289 as well.

No need to fix for the backport in Nautilus: ceph#38173
since the bugs are occured by adding additional code to
the cherry-pick specifically for Octopus.

fixes: https://tracker.ceph.com/issues/49891

Signed-off-by: Kamoltat <ksirivad@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neha-ojha neha-ojha neha-ojha approved these changes

Assignees

No one assigned

Labels

core mgr nautilus-batch-1 nautilus point releases needs-qa wip-yuri4-testing

Projects

None yet

Milestone

nautilus

Development

Successfully merging this pull request may close these issues.

3 participants

@kamoltat @neha-ojha @yuriw