Skip to content

mgr/progress: progress module on/off option#37488

Merged
jdurgin merged 1 commit intoceph:masterfrom
kamoltat:wip-mgr-progress-turn-off-option
Nov 17, 2020
Merged

mgr/progress: progress module on/off option#37488
jdurgin merged 1 commit intoceph:masterfrom
kamoltat:wip-mgr-progress-turn-off-option

Conversation

@kamoltat
Copy link
Member

@kamoltat kamoltat commented Sep 30, 2020 •
edited
Loading

Due to this module affecting the performance
of other module, we have decided to make it
optional for this module to on or off

Fixes: https://tracker.ceph.com/issues/47238

Signed-off-by: Kamoltat ksirivad@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@kamoltat kamoltat added the mgr label Sep 30, 2020
@kamoltat kamoltat requested a review from jdurgin September 30, 2020 05:58
@kamoltat kamoltat force-pushed the wip-mgr-progress-turn-off-option branch from 9ade77b to 969e358 Compare October 26, 2020 14:40
@kamoltat kamoltat changed the title mgr/progress: remove progress from always on mgr/progress: progress module on/off option Oct 26, 2020
@kamoltat kamoltat force-pushed the wip-mgr-progress-turn-off-option branch from 969e358 to 4443d4c Compare October 27, 2020 05:42
jdurgin
jdurgin reviewed Oct 27, 2020
View reviewed changes
jdurgin
jdurgin reviewed Oct 27, 2020
View reviewed changes
jdurgin
jdurgin reviewed Oct 27, 2020
View reviewed changes
jdurgin
jdurgin reviewed Oct 27, 2020
View reviewed changes
Copy link
Member

@jdurgin jdurgin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, could use a test with the progress module off (maybe a copy of qa/suites/rados/singleton/all/pg-autoscaler.yaml that turns of the progress module (e.g. adds an

- exec:
    client.0:
    - ceph progress off

before running the test))

@kamoltat kamoltat force-pushed the wip-mgr-progress-turn-off-option branch 4 times, most recently from da7e967 to 2cb0eee Compare October 29, 2020 08:11
@neha-ojha
Copy link
Member

neha-ojha commented Oct 30, 2020

@kamoltat Could you please attach https://tracker.ceph.com/issues/47238 to your commit?

@LenzGr
Copy link
Contributor

LenzGr commented Oct 30, 2020

Note that Ceph Dashboard displays progress information in its status bar. Have you tested how disabling this module affects the dashboard?

@kamoltat kamoltat force-pushed the wip-mgr-progress-turn-off-option branch 3 times, most recently from afbb016 to 2734e19 Compare October 30, 2020 13:53
@kamoltat kamoltat force-pushed the wip-mgr-progress-turn-off-option branch 2 times, most recently from 8bfe4e7 to b4c914b Compare November 4, 2020 06:46
@kamoltat kamoltat force-pushed the wip-mgr-progress-turn-off-option branch from b4c914b to a86b319 Compare November 5, 2020 07:19
@kamoltat
Copy link
Member Author

kamoltat commented Nov 6, 2020

https://pulpito.ceph.com/ksirivad-2020-11-05_15:49:33-rados:mgr-wip-mgr-progress-turn-off-option-distro-basic-smithi/

neha-ojha
neha-ojha reviewed Nov 6, 2020
View reviewed changes
Copy link
Member

@neha-ojha neha-ojha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamoltat We should add release notes in https://github.com/ceph/ceph/blob/master/PendingReleaseNotes and docs for this feature.

@kamoltat kamoltat force-pushed the wip-mgr-progress-turn-off-option branch from a86b319 to 17eaa20 Compare November 9, 2020 14:11
neha-ojha
neha-ojha reviewed Nov 9, 2020
View reviewed changes
@kamoltat kamoltat force-pushed the wip-mgr-progress-turn-off-option branch 6 times, most recently from 95a2262 to 3d39d48 Compare November 12, 2020 09:17
@kamoltat
Copy link
Member Author

kamoltat commented Nov 12, 2020

Jenkins retest this please

@kamoltat
Copy link
Member Author

kamoltat commented Nov 12, 2020

https://pulpito.ceph.com/ksirivad-2020-11-12_12:19:57-rados:mgr-wip-mgr-progress-turn-off-option-distro-basic-smithi/

@kamoltat
mgr/progress: introduce turn off/on feature
993bb02 
progress module can be turned off/on by using
the commands: 'progress off' and 'progress on'

As well as refractoring teuthology test suite
to prevent future bugs that can possibly occur

fixes: https://tracker.ceph.com/issues/47238

Signed-off-by: kamoltat <ksirivad@redhat.com>
@kamoltat kamoltat force-pushed the wip-mgr-progress-turn-off-option branch from 3d39d48 to 993bb02 Compare November 16, 2020 03:49
@kamoltat
Copy link
Member Author

kamoltat commented Nov 16, 2020

https://pulpito.ceph.com/ksirivad-2020-11-16_07:16:50-rados-wip-mgr-progress-turn-off-option-distro-basic-smithi/

@neha-ojha
Copy link
Member

neha-ojha commented Nov 16, 2020

jenkins test api

@kamoltat
Copy link
Member Author

kamoltat commented Nov 17, 2020

@neha-ojha @jdurgin latest run had 14 fails that I think are not related to my PR and is consistent with the failures in the master branch. I think the PR is ready to merge. What do you guys think?

https://pulpito.ceph.com/ksirivad-2020-11-16_07:16:50-rados-wip-mgr-progress-turn-off-option-distro-basic-smithi/

@neha-ojha
Copy link
Member

neha-ojha commented Nov 17, 2020

@neha-ojha @jdurgin latest run had 14 fails that I think are not related to my PR and is consistent with the failures in the master branch. I think the PR is ready to merge. What do you guys think?

https://pulpito.ceph.com/ksirivad-2020-11-16_07:16:50-rados-wip-mgr-progress-turn-off-option-distro-basic-smithi/

@kamoltat I think so! None of the failures are related.

@neha-ojha neha-ojha requested a review from jdurgin November 17, 2020 21:32
@jdurgin jdurgin merged commit c2b9152 into ceph:master Nov 17, 2020
@kamoltat kamoltat mentioned this pull request Nov 18, 2020
Merged
3 tasks
@smithfarm smithfarm mentioned this pull request Nov 30, 2020
Closed
@kamoltat kamoltat mentioned this pull request Feb 4, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdurgin jdurgin jdurgin approved these changes

@neha-ojha neha-ojha neha-ojha approved these changes

Assignees

No one assigned

Labels

core mgr needs-qa

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kamoltat @neha-ojha @LenzGr @jdurgin