Skip to content

msg/async: update refcount and perf counter properly#31929

Merged
tchaikov merged 2 commits intoceph:masterfrom
majianpeng:msg-async-bugfix
Jan 7, 2020
Merged

msg/async: update refcount and perf counter properly#31929
tchaikov merged 2 commits intoceph:masterfrom
majianpeng:msg-async-bugfix

Conversation

@majianpeng
Copy link
Member

@majianpeng majianpeng commented Dec 2, 2019

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@tchaikov tchaikov added bug-fix messenger Issues involving one of the Ceph messenger implementations labels Dec 2, 2019
@majianpeng
Copy link
Member Author

majianpeng commented Dec 2, 2019

retest this please

@tchaikov
Copy link
Contributor

tchaikov commented Dec 2, 2019

jenkins test make check

@majianpeng
Copy link
Member Author

majianpeng commented Dec 3, 2019

retest this please

@majianpeng
Copy link
Member Author

majianpeng commented Dec 13, 2019

@tchaikov . ping.

tchaikov
tchaikov reviewed Dec 13, 2019
View reviewed changes
@majianpeng
Copy link
Member Author

majianpeng commented Dec 18, 2019

retest this please

@majianpeng
Copy link
Member Author

majianpeng commented Dec 18, 2019

@tchaikov . which problem did cause make check always failed?

@majianpeng
Copy link
Member Author

majianpeng commented Dec 19, 2019

retest this please

@tchaikov
Copy link
Contributor

tchaikov commented Dec 19, 2019

jenkins test make check

1 similar comment
@majianpeng
Copy link
Member Author

majianpeng commented Dec 19, 2019

jenkins test make check

@majianpeng
Copy link
Member Author

majianpeng commented Dec 20, 2019

retest this please

@majianpeng
Copy link
Member Author

majianpeng commented Dec 23, 2019

jenkins test make check

@majianpeng
Copy link
Member Author

majianpeng commented Dec 28, 2019

retest this please

tchaikov
tchaikov reviewed Dec 28, 2019
View reviewed changes
@tchaikov
Copy link
Contributor

tchaikov commented Dec 28, 2019

retest this please

Jianpeng Ma added 2 commits December 31, 2019 10:20
msg/async: dec(l_msgr_active_connections) when unregister anonymous c…
550c447 
…onnection

When do all in one test,  l_msgr_active_connection don't decrease when
client shutdown.
This bug introduced by 5b41e12.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
msg/async: don't forget dec(Worker::references) when met error.
5cf027d 
This will cause unbalance between workes.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
@majianpeng
Copy link
Member Author

majianpeng commented Jan 1, 2020

retest this please

@tchaikov
Copy link
Contributor

tchaikov commented Jan 6, 2020

jenkins test make check

@tchaikov
Copy link
Contributor

tchaikov commented Jan 7, 2020

http://pulpito.ceph.com/kchai-2020-01-07_01:48:07-rados-wip-kefu-testing-2020-01-07-0032-distro-basic-smithi/

failures fixed / tracked by

@tchaikov tchaikov changed the title Msg async bugfix msg/async: update refcount and perf counter properly Jan 7, 2020
@tchaikov tchaikov merged commit b59cc67 into ceph:master Jan 7, 2020
@majianpeng majianpeng deleted the msg-async-bugfix branch January 8, 2020 01:29
@idryomov idryomov mentioned this pull request Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaikov tchaikov tchaikov approved these changes

Assignees

No one assigned

Labels

bug-fix messenger Issues involving one of the Ceph messenger implementations needs-qa wip-kefu-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@majianpeng @tchaikov