qa/tasks/mgr/test_orchestrator_cli: fix service action tests#32518
Merged
tchaikov merged 1 commit intoceph:masterfrom Jan 7, 2020
Merged
qa/tasks/mgr/test_orchestrator_cli: fix service action tests#32518tchaikov merged 1 commit intoceph:masterfrom
tchaikov merged 1 commit intoceph:masterfrom
Conversation
in b77f0c7, "reload" service[-instance] action was dropped. so replace "reload" with "restart" in the related tests. Signed-off-by: Kefu Chai <kchai@redhat.com>
Contributor
Author
|
this change should address the failure of http://pulpito.ceph.com/kchai-2020-01-07_01:48:07-rados-wip-kefu-testing-2020-01-07-0032-distro-basic-smithi/4643357/ |
This was referenced Jan 7, 2020
This was referenced Jan 7, 2020
toabctl
approved these changes
Jan 7, 2020
sebastian-philipp
approved these changes
Jan 7, 2020
Contributor
|
wondering if we really need a qa run for this. This is clearly and undoubtedly an improvement with very little probability for introducing a regression. @tchaikov mind if we merge this right away? |
Contributor
Author
|
@sebastian-philipp i'd like to run it through the test which previously failed at least to verify the fix. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in b77f0c7, "reload"
service[-instance] action was dropped. so replace "reload" with
"restart" in the related tests.
Signed-off-by: Kefu Chai kchai@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox