mon: should not take non-tell commands as tell ones#32517
Merged
tchaikov merged 1 commit intoceph:masterfrom Jan 8, 2020
Merged
mon: should not take non-tell commands as tell ones#32517tchaikov merged 1 commit intoceph:masterfrom
tchaikov merged 1 commit intoceph:masterfrom
Conversation
this change addresses a regression introduced by a2c3479. in which, a new flag, 'FLAG_TELL' was added. and it's used to check if a command is "TELL" command. if it is, it's added to the tell/asok command registry and monitor will handle the commands in this registry using asok hooks. but there are some commands whose flag is "HIDDEN". and after a2c3479, is_tell() takes HIDDEN commands as TELL command. that's why `ceph_test_admin_socket_output --all` fails. because, "mds freeze" is now wrongly considered as a TELL command. but monitor is not able to handle is using the asok hooks. after this change, is_tell() will not mistake "mds freeze" as a TELL command anymore. Signed-off-by: Kefu Chai <kchai@redhat.com>
Contributor
Author
|
this change should address the failure of http://pulpito.ceph.com/kchai-2020-01-07_01:48:07-rados-wip-kefu-testing-2020-01-07-0032-distro-basic-smithi/4643473/ |
This was referenced Jan 7, 2020
This was referenced Jan 7, 2020
jdurgin
approved these changes
Jan 8, 2020
Member
jdurgin
left a comment
There was a problem hiding this comment.
nice catch, I swear we've had the same exact bug in a flag check like this before, where we assumed power of 2 flags but incremented them sequentially instead
neha-ojha
approved these changes
Jan 8, 2020
Contributor
Author
|
test finished. but failed due to fixed by #32549 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this change addresses a regression introduced by a2c3479. in which, a
new flag, 'FLAG_TELL' was added. and it's used to check if a command is
"TELL" command. if it is, it's added to the tell/asok command registry
and monitor will handle the commands in this registry using asok hooks.
but there are some commands whose flag is "HIDDEN". and after
a2c3479, is_tell() takes HIDDEN commands as TELL command. that's why
ceph_test_admin_socket_output --allfails. because, "mds freeze" isnow wrongly considered as a TELL command. but monitor is not able to
handle is using the asok hooks.
after this change, is_tell() will not mistake "mds freeze" as a TELL
command anymore.
Signed-off-by: Kefu Chai kchai@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox