Skip to content

qa/tasks/mgr/test_progress.py: fix bug in 9b4dbf0#29385

Merged
tchaikov merged 2 commits intoceph:masterfrom
kamoltat:wip-qa-tasks-mgr-test-progress-bug-fix
Aug 9, 2019
Merged

qa/tasks/mgr/test_progress.py: fix bug in 9b4dbf0#29385
tchaikov merged 2 commits intoceph:masterfrom
kamoltat:wip-qa-tasks-mgr-test-progress-bug-fix

Conversation

@kamoltat
Copy link
Member

@kamoltat kamoltat commented Jul 29, 2019 •
edited
Loading

follow-up-fix for 9b4dbf0

basically we wanna look at the list that has inprogress events and not the list that has inprogress+complete events

Fixes: http://pulpito.ceph.com/kchai-2019-07-28_14:30:09-rados-wip-kefu2-testing-2019-07-28-1941-distro-basic-mira/4160881/

Signed-off-by: Kamoltat (Junior) Sirivadhna ksirivad@redhat.com

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

@kamoltat
Copy link
Member Author

kamoltat commented Jul 29, 2019

#29368

@tchaikov
Copy link
Contributor

tchaikov commented Jul 30, 2019

http://pulpito.ceph.com/kchai-2019-07-30_05:20:11-rados-master-distro-basic-smithi/

@tchaikov
Copy link
Contributor

tchaikov commented Jul 30, 2019 

2019-07-30T05:37:43.148 INFO:tasks.cephfs_test_runner:
2019-07-30T05:37:43.148 INFO:tasks.cephfs_test_runner:======================================================================
2019-07-30T05:37:43.148 INFO:tasks.cephfs_test_runner:ERROR: test_osd_came_back (tasks.mgr.test_progress.TestProgress)
2019-07-30T05:37:43.148 INFO:tasks.cephfs_test_runner:----------------------------------------------------------------------
2019-07-30T05:37:43.148 INFO:tasks.cephfs_test_runner:Traceback (most recent call last):
2019-07-30T05:37:43.148 INFO:tasks.cephfs_test_runner:  File "/home/teuthworker/src/github.com_kamoltat_ceph_wip-qa-tasks-mgr-test-progress-bug-fix/qa/tasks/mgr/test_progress.py", line 202, in test_osd_came_back
2019-07-30T05:37:43.149 INFO:tasks.cephfs_test_runner:    ev2 = self._simulate_back_in([0], ev1)
2019-07-30T05:37:43.149 INFO:tasks.cephfs_test_runner:  File "/home/teuthworker/src/github.com_kamoltat_ceph_wip-qa-tasks-mgr-test-progress-bug-fix/qa/tasks/mgr/test_progress.py", line 128, in _simulate_back_in
2019-07-30T05:37:43.149 INFO:tasks.cephfs_test_runner:    timeout=self.EVENT_CREATION_PERIOD)
2019-07-30T05:37:43.149 INFO:tasks.cephfs_test_runner:  File "/home/teuthworker/src/github.com_kamoltat_ceph_wip-qa-tasks-mgr-test-progress-bug-fix/qa/tasks/ceph_test_case.py", line 145, in wait_until_equal
2019-07-30T05:37:43.149 INFO:tasks.cephfs_test_runner:    elapsed, expect_val, val
2019-07-30T05:37:43.149 INFO:tasks.cephfs_test_runner:RuntimeError: Timed out after 5 seconds waiting for 1 (currently 0)

http://pulpito.ceph.com/kchai-2019-07-30_05:20:11-rados-master-distro-basic-smithi/4164376/

@tchaikov
Copy link
Contributor

tchaikov commented Aug 1, 2019

@kamoltat needs rebase

@kamoltat kamoltat force-pushed the wip-qa-tasks-mgr-test-progress-bug-fix branch from ec49d7e to e89895a Compare August 2, 2019 17:39
@kamoltat
Copy link
Member Author

kamoltat commented Aug 2, 2019

Hi all sorry I made a mistake on git :(

@kamoltat kamoltat force-pushed the wip-qa-tasks-mgr-test-progress-bug-fix branch 3 times, most recently from cd7e9eb to b8f65c7 Compare August 5, 2019 14:10
kamoltat added 2 commits August 5, 2019 11:03
@kamoltat
qa/tasks/mgr/test_progress.py: fix bug in 9b4dbf0
baa7141 
follow-up-fix for 9b4dbf0

basically we wanna look at the list that has inprogress events to inprogress+complete

Fixes: http://pulpito.ceph.com/kchai-2019-07-28_14:30:09-rados-wip-kefu2-testing-2019-07-28-1941-distro-basic-mira/4160881/

Signed-off-by: Kamoltat (Junior) Sirivadhna <ksirivad@redhat.com>
@kamoltat
qa/tasks/mgr/test_progress.py: resolve dictionary runtime error
1322f90 
Think the problem is how we are using dictionary.item() in
for loop causing runtime error therefore the event didn't
get created so we convert it to list(dictionary).

Fixes http://pulpito.ceph.com/kchai-2019-07-28_14:30:09-rados-wip-kefu2-testing-2019-07-28-1941-distro-basic-mira/4160881/

Also the same fix as: ceph#28840

Signed-off-by: Kamoltat (Junior) Sirivadhna <ksirivad@redhat.com>
@kamoltat kamoltat force-pushed the wip-qa-tasks-mgr-test-progress-bug-fix branch from 3cdf26f to 1322f90 Compare August 5, 2019 15:07
@tchaikov
Copy link
Contributor

tchaikov commented Aug 9, 2019

failures are tracked by

@tchaikov tchaikov merged commit 3efc51f into ceph:master Aug 9, 2019
kamoltat added a commit to kamoltat/ceph that referenced this pull request Aug 13, 2019
@kamoltat
mgr/progress & mgr/test_progress.py bug fix ceph#29385
9857457 
fix syntax error: events/_events

fix issue: https://tracker.ceph.com/issues/40618?next_issue_id=40616&prev_issue_id=40619#note-7

Signed-off-by: Kamoltat (Junior) Sirivadhna <ksirivad@redhat.com>
kamoltat added a commit to kamoltat/ceph that referenced this pull request Aug 14, 2019
@kamoltat
mgr/progress & mgr/test_progress.py bug fix ceph#29385
5cbc974 
fix syntax error: events/_events

fix issue: https://tracker.ceph.com/issues/40618?next_issue_id=40616&prev_issue_id=40619#note-7

Signed-off-by: Kamoltat (Junior) Sirivadhna <ksirivad@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdurgin jdurgin jdurgin approved these changes

Assignees

No one assigned

Labels

bug-fix needs-qa tests wip-kefu-testing wip-sage-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kamoltat @tchaikov @jdurgin @liewegas