mgr/progress: fix dictionary change during iteration error#28840
Closed
kamoltat wants to merge 1 commit intoceph:masterfrom
Closed
mgr/progress: fix dictionary change during iteration error#28840kamoltat wants to merge 1 commit intoceph:masterfrom
kamoltat wants to merge 1 commit intoceph:masterfrom
Conversation
Provide a fix for the bug where there is runtime error for when dictionary change during iteration. Fix by just making a copy of the dictionary using list() Signed-off-by: Kamoltat (Junior) Sirivadhna <ksirivad@redhat.com>
Member
|
Hey @kamoltat, could you include the tracker reference for the bug that this PR is fixing in the commit message? See https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#tag-the-commit |
Member
|
if it's possible for a 2nd thread to change the dictionary, do we need to introduce a lock for accessing it instead? |
jdurgin
approved these changes
Jul 5, 2019
Member
jdurgin
left a comment
There was a problem hiding this comment.
I see what you mean now, about changing the dictionary during the loop. Looks good!
Contributor
|
@kamoltat could you take a look? the tested branch contains this PR. |
sebastian-philipp
approved these changes
Jul 16, 2019
tchaikov
reviewed
Jul 22, 2019
3 tasks
tchaikov
approved these changes
Jul 22, 2019
sebastian-philipp
approved these changes
Jul 25, 2019
3 tasks
This was referenced Jul 30, 2019
kamoltat
added a commit
to kamoltat/ceph
that referenced
this pull request
Jul 30, 2019
Think the problem is how we are using dictionary.item() in for loop causing runtime error therefore the event didn't get created so we convert it to list(dictionary). Fixes http://pulpito.ceph.com/kchai-2019-07-28_14:30:09-rados-wip-kefu2-testing-2019-07-28-1941-distro-basic-mira/4160881/ Also the same fix as: ceph#28840 Signed-off-by: Kamoltat (Junior) Sirivadhna <ksirivad@redhat.com>
kamoltat
added a commit
to kamoltat/ceph
that referenced
this pull request
Aug 2, 2019
Think the problem is how we are using dictionary.item() in for loop causing runtime error therefore the event didn't get created so we convert it to list(dictionary). Fixes http://pulpito.ceph.com/kchai-2019-07-28_14:30:09-rados-wip-kefu2-testing-2019-07-28-1941-distro-basic-mira/4160881/ Also the same fix as: ceph#28840 Signed-off-by: Kamoltat (Junior) Sirivadhna <ksirivad@redhat.com>
kamoltat
added a commit
to kamoltat/ceph
that referenced
this pull request
Aug 5, 2019
Think the problem is how we are using dictionary.item() in for loop causing runtime error therefore the event didn't get created so we convert it to list(dictionary). Fixes http://pulpito.ceph.com/kchai-2019-07-28_14:30:09-rados-wip-kefu2-testing-2019-07-28-1941-distro-basic-mira/4160881/ Also the same fix as: ceph#28840 Signed-off-by: Kamoltat (Junior) Sirivadhna <ksirivad@redhat.com>
kamoltat
added a commit
to kamoltat/ceph
that referenced
this pull request
Aug 5, 2019
Think the problem is how we are using dictionary.item() in for loop causing runtime error therefore the event didn't get created so we convert it to list(dictionary). Fixes http://pulpito.ceph.com/kchai-2019-07-28_14:30:09-rados-wip-kefu2-testing-2019-07-28-1941-distro-basic-mira/4160881/ Also the same fix as: ceph#28840 Signed-off-by: Kamoltat (Junior) Sirivadhna <ksirivad@redhat.com>
kamoltat
added a commit
to kamoltat/ceph
that referenced
this pull request
Aug 5, 2019
Think the problem is how we are using dictionary.item() in for loop causing runtime error therefore the event didn't get created so we convert it to list(dictionary). Fixes http://pulpito.ceph.com/kchai-2019-07-28_14:30:09-rados-wip-kefu2-testing-2019-07-28-1941-distro-basic-mira/4160881/ Also the same fix as: ceph#28840 Signed-off-by: Kamoltat (Junior) Sirivadhna <ksirivad@redhat.com>
Contributor
|
any update on this? |
Member
|
superseded by #29035 |
Contributor
|
also #29807 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a fix for the bug where
there is runtime error for when
dictionary change during iteration.
Fix by just making a copy of the
dictionary using list()
Fixes: http://tracker.ceph.com/issues/40618
Signed-off-by: Kamoltat (Junior) Sirivadhna ksirivad@redhat.com