unit tests for FileStore::_detect_fs when running on ext4#165
Conversation
unit tests are added in test/filestore/store_test.cc for the FileStore::_detect_fs method, when using ext4. It tests the following situations: * without user_xattr, ext4 fails * mounted with user_xattr, ext4 fails if filestore_xattr_use_omap is false * mounted with user_xattr, ext4 succeeds if filestore_xattr_use_omap is true The tests are grouped in an ext4 dedicated class TEST(EXT4StoreTest, _detect_fs) The qa/workunits/filestore/filestore.sh script is added to prepare the environment required for the unit tests ( create an image file, formats it with ext4 etc.). It runs ceph_test_filestore with a sudo to allow it to mount(2) and umount(2) the ext4 file system. It is called with ceph_test_filestore --gtest_filter=EXT4StoreTest.* to only run the ext4 dependent tests. The filestore.sh script is meant to be used as part of teuthology in order to increase the code coverage for src/os/FileStore.cc. It is self tested and can be checked from the source directory with CEPH_TEST_FILESTORE=../../../src/ceph_test_filestore filestore.sh TEST http://tracker.ceph.com/issues/4321 refs #4321 Signed-off-by: Loic Dachary <loic@dachary.org>
liewegas
pushed a commit
that referenced
this pull request
May 8, 2013
unit tests for FileStore::_detect_fs when running on ext4
liewegas
pushed a commit
that referenced
this pull request
Dec 14, 2016
erasure-code: isa plugin thrashods suite Reviewed-by: Samuel Just <sam.just@inktank.com>
liewegas
pushed a commit
that referenced
this pull request
Dec 14, 2016
Do not run local handling fix if local parameter is not found.
theanalyst
pushed a commit
to theanalyst/ceph
that referenced
this pull request
Mar 13, 2018
tests: ceph-disk: ignore E722 in flake8 test
liewegas
pushed a commit
to liewegas/ceph
that referenced
this pull request
Nov 5, 2021
Minor UI updates
andriytk
pushed a commit
to andriytk/cortx-rgw
that referenced
this pull request
May 3, 2022
…ph#165) * rgw_sal_motr: [CORTX-27628] Support Multipart Complete API in RGW Handle deletion of old object during object overwrite situation. Fixed invalid part issue for 1000 parts. Signed-off-by: Dattaprasad Govekar <dattaprasad.govekar@seagate.com> * rgw_op: [CORTX-27628] Fix empty etag issue in the response of Complete API Problem: The computed Etag of all parts is not assigned to appropriate state/variable, thus, making empty etag in the response of Complete API. Resolution: The computer Etag is assigned to state/variable used in generating the Complete API response. Signed-off-by: Dattaprasad Govekar <dattaprasad.govekar@seagate.com>
robbat2
pushed a commit
to robbat2/ceph
that referenced
this pull request
Feb 1, 2023
…5/backport-heap-cmd-fix osd, mds: fix the "heap" admin cmd printing always to error stream
irq0
pushed a commit
to irq0/ceph
that referenced
this pull request
Aug 18, 2023
rgw/gc: New GC implementation after versioning redesign
Merged
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unit tests are added in test/filestore/store_test.cc for the
FileStore::_detect_fs method, when using ext4. It tests the following
situations:
The tests are grouped in an ext4 dedicated class
TEST(EXT4StoreTest, _detect_fs)
The qa/workunits/filestore/filestore.sh script is added to prepare the
environment required for the unit tests ( create an image file,
formats it with ext4 etc.). It runs ceph_test_filestore with a sudo
to allow it to mount(2) and umount(2) the ext4 file system. It is
called with
ceph_test_filestore --gtest_filter=EXT4StoreTest.*
to only run the ext4 dependent tests.
The filestore.sh script is meant to be used as part of teuthology
in order to increase the code coverage for src/os/FileStore.cc. It is
self tested and can be checked from the source directory with
CEPH_TEST_FILESTORE=../../../src/ceph_test_filestore filestore.sh TEST
http://tracker.ceph.com/issues/4321 refs #4321
Signed-off-by: Loic Dachary loic@dachary.org