crush/mapper: fix divide-by-0 in straw2 (hammer)#4321
Closed
liewegas wants to merge 1 commit intoceph:hammerfrom
Closed
crush/mapper: fix divide-by-0 in straw2 (hammer)#4321liewegas wants to merge 1 commit intoceph:hammerfrom
liewegas wants to merge 1 commit intoceph:hammerfrom
Conversation
If the item weight is 0 we don't want to divide; instead draw a minimal value. Fixes: ceph#11357 Reported-by: Yann Dupont <yd@objoo.org> Tested-by: Yann Dupont <yd@objoo.org> Signed-off-by: Sage Weil <sage@redhat.com>
7d236a6 to
64d1e90
Compare
|
could you cherry pick 64d1e90 instead to help with cross referencing ? |
Member
Author
|
yeah i'll cherry-pick and push manually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the item weight is 0 we don't want to divide; instead draw a minimal
value.
Fixes: #11357 Reported-by: Yann Dupont yd@objoo.org Tested-by: Yann Dupont
yd@objoo.org Signed-off-by: Sage Weil sage@redhat.com