This repository was archived by the owner on Nov 7, 2022. It is now read-only.
Revert "Revert "Upgrade opencensus-proto version to v0.2.0. (#490)" (…#506
Merged
songy23 merged 1 commit intocensus-instrumentation:masterfrom Mar 28, 2019
Merged
Conversation
Contributor
Author
|
Roll forward #490. @bogdandrutu helped debug the previous issue. The bug that ocagent exporter cannot talk to agent/collector is not because of proto changes. It's because of a gRPC change, which is fixed by #501. |
bogdandrutu
approved these changes
Mar 28, 2019
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
==========================================
- Coverage 58.81% 58.75% -0.07%
==========================================
Files 69 69
Lines 4507 4507
==========================================
- Hits 2651 2648 -3
- Misses 1692 1695 +3
Partials 164 164
Continue to review full report at Codecov.
|
This was referenced Mar 28, 2019
fivesheep
pushed a commit
to fivesheep/opencensus-service
that referenced
this pull request
Jun 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…#503)"
This reverts commit b9f473c.