Codecov Report

Merging #503 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #503      +/-   ##
=========================================
+ Coverage   58.13%   58.2%   +0.06%     
=========================================
  Files          69      69              
  Lines        4500    4500              
=========================================
+ Hits         2616    2619       +3     
+ Misses       1719    1716       -3     
  Partials      165     165

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 405c9e3...12568e9. Read the comment docs.

Oh oh, what happened?

@odeke-em I'm not sure but the RPC between agent and collector in the demo/traces is broken with the upgrade, reverting it fixes the issue.

Using https://github.com/grpc/grpc-go/releases/tag/v1.18.1 also fixes demo/trace perhaps will go with that instead of the revert.

Using https://github.com/grpc/grpc-go/releases/tag/v1.18.1 also fixes demo/trace perhaps will go with that instead of the revert.

Great to know, so the issue may be the RPC client and server generated with protoc v3.6.1 don't work with this gRPC version.

Per conversation on issue #502 going with the revert.