Skip to content

Update op-geth for celo10 branch#292

Merged
ezdac merged 3 commits intocelo10from
update/op-geth
Jan 13, 2025
Merged

Update op-geth for celo10 branch#292
ezdac merged 3 commits intocelo10from
update/op-geth

Conversation

@ezdac
Copy link
Copy Markdown

@ezdac ezdac commented Jan 13, 2025

Although we will soon upgrade the default branch to celo11, we want to
keep the tips of op-geth/celoXX / optimism/celoXX branches synced to it's respective counterpart.
This is a follow-up to #289, since the weekly github action seemed to have force-pushed and closed the pr.

ezdac and others added 3 commits January 13, 2025 11:24
Update the go package dependency and the devnet
docker container reference of the `l2` service
to the latest commit (`0162ce9d029819807bcba2dc94875888c72aa88d`)
in the `celo10` ref.
@socket-security
Copy link
Copy Markdown

socket-security bot commented Jan 13, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/cffi@1.17.1 🔁 pypi/cffi@1.15.1 None +124 68.1 MB Armin.Rigo, alexgaynor, fijal, ...5 more

View full report↗︎

@socket-security
Copy link
Copy Markdown

socket-security bot commented Jan 13, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@ezdac
Copy link
Copy Markdown
Author

ezdac commented Jan 13, 2025

@SocketSecurity ignore pypi/cffi@1.17.1

@ezdac ezdac self-assigned this Jan 13, 2025
@ezdac ezdac requested a review from karlb January 13, 2025 10:46
@ezdac
Copy link
Copy Markdown
Author

ezdac commented Jan 13, 2025

The failing test is flaky and very likely not caused by the changes.

@ezdac ezdac merged commit 16f5156 into celo10 Jan 13, 2025
@ezdac ezdac deleted the update/op-geth branch January 13, 2025 13:46
jcortejoso added a commit that referenced this pull request Jan 22, 2025
* [Automatic] - Update op-geth dependencies

Update the go package dependency and the devnet
docker container reference of the `l2` service
to the latest commit (`0162ce9d029819807bcba2dc94875888c72aa88d`)
in the `celo10` ref.

* Adapt address-getters to op-geth library changes

* Update cffi python package

---------

Co-authored-by: Javier Cortejoso <javier.cortejoso@gmail.com>
piersy added a commit that referenced this pull request Feb 5, 2025
palango added a commit that referenced this pull request Feb 6, 2025
* Fix missing import in celo-migrate/main.go (#305)

* Fix update-geth.sh (#304)

The script was not substituting the go.mod file and the Dockerfile since the
regexes were not matching.

The regex for the Dockerfile contained '@sha256:' which perl was
interpreting as a global symbol, in order to interpret it literally we
needed to escape the '@'.

The regex for the go.mod file contained an extra space before the arrow
'go-ethereum .* => ', in a tidied go.mod file there is one space between
the package name and the arrow '=>'.

Also adds failure output so that it's easier to debug where this is
going wrong.

---------

Co-authored-by: Karl Bartel <karl@karl.berlin>
Co-authored-by: Paul Lange <palango@users.noreply.github.com>

* The substitution was failing in the docker file since (#309)

The substitution \1 and the beginning of the image hash together created
\150 which perl interprets as the octal character code for h.

To prevent this we need to use the \${1} notation to reference captured
groups.

* Revert "Update op-geth for `celo10` branch (#292)"

This reverts commit 16f5156.

* Update op-geth to celo-v2.0.0-rc3

* Reinstate requirements

---------

Co-authored-by: Karl Bartel <karl@karl.berlin>
Co-authored-by: Paul Lange <palango@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants