Skip to content

[Automatic] - Update op-geth dependencies#289

Closed
github-actions[bot] wants to merge 3 commits intocelo10from
update/op-geth
Closed

[Automatic] - Update op-geth dependencies#289
github-actions[bot] wants to merge 3 commits intocelo10from
update/op-geth

Conversation

@github-actions
Copy link
Copy Markdown

Update the go package dependency and the devnet
docker container reference of the l2 service
to the latest commit (0162ce9d029819807bcba2dc94875888c72aa88d)
in the celo10 ref.

Update the go package dependency and the devnet
docker container reference of the `l2` service
to the latest commit (`0162ce9d029819807bcba2dc94875888c72aa88d`)
in the `celo10` ref.
@github-actions
Copy link
Copy Markdown
Author

github-actions bot commented Jan 7, 2025

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jan 7, 2025
@ezdac ezdac self-requested a review January 7, 2025 08:54
@ezdac ezdac self-assigned this Jan 7, 2025
@ezdac ezdac force-pushed the update/op-geth branch 2 times, most recently from 4ed6cd7 to e4269e9 Compare January 7, 2025 13:10
@ezdac ezdac removed the Stale label Jan 7, 2025
@socket-security
Copy link
Copy Markdown

socket-security bot commented Jan 7, 2025

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/cffi@1.17.1 environment, eval, filesystem, network, shell, unsafe +188 691 MB Armin.Rigo, alexgaynor, fijal, ...5 more

🚮 Removed packages: pypi/cffi@1.15.1

View full report↗︎

@socket-security
Copy link
Copy Markdown

socket-security bot commented Jan 7, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1, pypi/cffi@1.17.1

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@ezdac
Copy link
Copy Markdown

ezdac commented Jan 7, 2025

@SocketSecurity ignore pypi/cffi@1.17.1

@ezdac
Copy link
Copy Markdown

ezdac commented Jan 8, 2025

The failing tests should be unrelated to the changes, since the currently also fail in other PRs that don't employ the updated execution client.

@ezdac
Copy link
Copy Markdown

ezdac commented Jan 13, 2025

Interesting, the github action force pushes to the branch and closes the pr (why close it?).
This is fine when the branch doesn't get any necessary manual changes and is only managed by the bot alone.
In this case here the changes got rolled back in favor of a newer geth version, which undesirable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants