Use blocklist and multi-gas-pools only while sequencing by ezdac · Pull Request #363 · celo-org/op-geth

ezdac · 2025-04-03T13:00:09Z

We recognized that there might be an issue that validators can't derive from L1 when it has a different local state than the block-builder / sequencer:

if a blocklist is poisoned / has a blocked fee-currency or tx that the sequencer hadn't while building
if the multigaspool parameters are configured differently
if the validator has txs in the mempool that fail during debit/credit and users query "pending" block information, which potentially could also lead to poisoning the blocklist

This is why we have to disable the blocklist and specific fee currency pools in the multigaspool while deriving from L1 ( payloadAttributes.noTxs==true).

In addition to this, we also disable filtering the allowlist or adding to the blocklist while building the pending block.

core/celo_multi_gaspool.go

miner/worker.go

core/celo_multi_gaspool.go

miner/worker.go

miner/celo_miner_test.go

miner/currency_blocklist.go

We want to be able to recognize when the passed in fee-currency does not have an individual multi-gas-pool set, e.g. when setting the remaining gas-allowance to 0 due to a fee-currency block.

Co-authored-by: piersy <pierspowlesland@gmail.com>

Co-Authored-by: piersy <pierspowlesland@gmail.com>

Co-authored-by: piersy <pierspowlesland@gmail.com>

* Only apply the blocklist filtering when node is not deriving from l1 * Only use a multigaspool when the node is not deriving from l1 * Add return value to multigaspools `PoolFor` We want to be able to recognize when the passed in fee-currency does not have an individual multi-gas-pool set, e.g. when setting the remaining gas-allowance to 0 due to a fee-currency block. * Change log-level to Err for fee-currency EVM error * Add flag to deactivate blocklists in workload * Add test for no blocklist in derivation / pending builder * Add comment clarifying parameter Co-authored-by: piersy <pierspowlesland@gmail.com> * Simplify multigaspool constructor Co-Authored-by: piersy <pierspowlesland@gmail.com> * Add context to test comments Co-authored-by: piersy <pierspowlesland@gmail.com> * Add warning log for blocked currency with non-multigaspool * Move fee-currency blocking up in function * Modify multi-gas-pool test --------- Co-authored-by: piersy <pierspowlesland@gmail.com> Fix intrinsic test

This should normally not happen, but we have to make sure that such a rare case won't crash geth nodes are cause stuck transactions that will get re-executed on every block. e2e(fee_currency): Refactor fee currency e2e tests (#212, #258) Refactors debug fee currency deployment ensuring fee currency cleanup. The geth-devmode predeployed "oracle3" is reused throughout the e2e tests for all dynamically deployed fee-currencies. However the tested fee-currencies are never removed from the FeeCurrencyDirectory. This causes the node to try to query exchange-rates for the leftover fee-currencies. This fails, because the oracle associated with the old fee-currency has a different token address assigned and thus causes a revert. This issue is not critical and only causes emission of a log message and some unneccessary evm calls, but it is better practice to clean up the fee-currency from the directory anyways. Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com> [squash]: e2e(ci): update foundry version to v1.1.0 (#380) e2e(fee_currency): Update error message assertion (#363) e2e(fee_currency): Fix account balance check (#266) e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261) Co-authored-by: Karl Bartel <karl.bartel@clabs.co> e2e(runner|fee_currency): Fix failing e2e test (#371) * Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees * Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e * Fix log assertion in e2e * Add several e2e tests for admin blocking API * Remove broadcast

ezdac force-pushed the ezdac/blocklist-only-on-sequencing branch from 304d0fc to cb17717 Compare April 3, 2025 13:17

ezdac mentioned this pull request Apr 3, 2025

Adjust fee currency blacklisting #345

Closed

ezdac force-pushed the ezdac/blocklist-only-on-sequencing branch from cb17717 to ef5955e Compare April 3, 2025 13:25