Skip to content

Fix account balance check#266

Merged
gastonponti merged 5 commits intocelo10from
gastonponti/fix-balance-check
Nov 6, 2024
Merged

Fix account balance check#266
gastonponti merged 5 commits intocelo10from
gastonponti/fix-balance-check

Conversation

@gastonponti
Copy link
Copy Markdown

@gastonponti gastonponti commented Oct 25, 2024 •
edited by piersy
Loading

Fixes a bug in the balance check of the state transition

The Value of Tx is always defined in Celo. In a cip-64 Tx, if the FeeCurrency is set to an erc20, the whole gas consumption (L1 fees, feeCap and priority) is calculated in that erc20.
We've been adding the Value to the gas consumption regardless it was or not Celo, which it was an error.

@piersy
Copy link
Copy Markdown

piersy commented Oct 28, 2024

Hey @gastonponti can you add a test to verify that this is working?

piersy
piersy approved these changes Nov 6, 2024
View reviewed changes
Copy link
Copy Markdown

@piersy piersy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looking good!

@gastonponti gastonponti merged commit 3072aa7 into celo10 Nov 6, 2024
@gastonponti gastonponti deleted the gastonponti/fix-balance-check branch November 6, 2024 16:16
karlb pushed a commit that referenced this pull request Dec 13, 2024
@gastonponti @karlb
Fix account balance check (#266)
236d4b7
karlb pushed a commit that referenced this pull request Dec 16, 2024
@gastonponti @karlb
Fix account balance check (#266)
7bef4d3
karlb pushed a commit that referenced this pull request Dec 17, 2024
@gastonponti @karlb
Fix account balance check (#266)
cdaa7ca
gastonponti added a commit that referenced this pull request Dec 17, 2024
@gastonponti
Fix account balance check (#266)
d4d6fc8
karlb pushed a commit that referenced this pull request Jan 27, 2025
@gastonponti @karlb
Fix account balance check (#266)
9315a23
karlb pushed a commit that referenced this pull request Jan 28, 2025
@gastonponti @karlb
Fix account balance check (#266)
f6aba20
karlb pushed a commit that referenced this pull request Feb 3, 2025
@gastonponti @karlb
Fix account balance check (#266)
fad3ba0
karlb pushed a commit that referenced this pull request Feb 11, 2025
@gastonponti @karlb
Fix account balance check (#266)
ac8b30d
piersy pushed a commit that referenced this pull request Apr 8, 2025
@gastonponti @piersy
Fix account balance check (#266)
a14bd3d
piersy pushed a commit that referenced this pull request Apr 9, 2025
@gastonponti @piersy
Fix account balance check (#266)
7ca1085
piersy pushed a commit that referenced this pull request Apr 9, 2025
@gastonponti @piersy
Fix account balance check (#266)
bb3ae4f
piersy pushed a commit that referenced this pull request Apr 9, 2025
@gastonponti @piersy
Fix account balance check (#266)
47c9b8c
piersy pushed a commit that referenced this pull request Apr 9, 2025
@gastonponti @piersy
Fix account balance check (#266)
c343fcd
piersy pushed a commit that referenced this pull request Apr 11, 2025
@gastonponti @piersy
Fix account balance check (#266)
e94f6d2
piersy pushed a commit that referenced this pull request Apr 11, 2025
@gastonponti @piersy
Fix account balance check (#266)
7011508
piersy pushed a commit that referenced this pull request Apr 11, 2025
@gastonponti @piersy
Fix account balance check (#266)
ce250b2
piersy pushed a commit that referenced this pull request Apr 11, 2025
@gastonponti @piersy
Fix account balance check (#266)
c1ce82d
piersy pushed a commit that referenced this pull request Apr 11, 2025
@gastonponti @piersy
Fix account balance check (#266)
806b0ae
piersy pushed a commit that referenced this pull request Apr 11, 2025
@gastonponti @piersy
Fix account balance check (#266)
c7e67e9
piersy pushed a commit that referenced this pull request Apr 11, 2025
@gastonponti @piersy
Fix account balance check (#266)
33ccfed
piersy pushed a commit that referenced this pull request Apr 11, 2025
@gastonponti @piersy
Fix account balance check (#266)
604acbb
piersy pushed a commit that referenced this pull request May 1, 2025
@gastonponti @piersy
Fix account balance check (#266)
348f70c
piersy pushed a commit that referenced this pull request May 1, 2025
@gastonponti @piersy
Fix account balance check (#266)
b2b8b3b
piersy pushed a commit that referenced this pull request May 2, 2025
@gastonponti @piersy
Fix account balance check (#266)
66a1e38
piersy pushed a commit that referenced this pull request May 6, 2025
@gastonponti @piersy
Fix account balance check (#266)
c90b45c
piersy pushed a commit that referenced this pull request May 6, 2025
@gastonponti @piersy
Fix account balance check (#266)
1e313ad
piersy pushed a commit that referenced this pull request May 8, 2025
@gastonponti @piersy
Fix account balance check (#266)
602de36
piersy pushed a commit that referenced this pull request May 12, 2025
@gastonponti @piersy
Fix account balance check (#266)
7d06bb0
piersy pushed a commit that referenced this pull request May 22, 2025
@gastonponti @piersy
Fix account balance check (#266)
616a51a
piersy pushed a commit that referenced this pull request May 22, 2025
@gastonponti @piersy
Fix account balance check (#266)
5258ba9
Kourin1996 pushed a commit that referenced this pull request Jul 20, 2025
@gastonponti @Kourin1996
Fix account balance check (#266)
48bb4a7
Kourin1996 pushed a commit that referenced this pull request Jul 21, 2025
@gastonponti @Kourin1996
Fix account balance check (#266)
4af7281
Kourin1996 pushed a commit that referenced this pull request Jul 26, 2025
@gastonponti @Kourin1996
Fix account balance check (#266)
33007b2
Kourin1996 pushed a commit that referenced this pull request Jul 28, 2025
@gastonponti @Kourin1996
Fix account balance check (#266)
85e5b11
Kourin1996 pushed a commit that referenced this pull request Jul 30, 2025
@palango @Kourin1996
refactor: Create FeeCurrencyContext in NewEVMBlockContext
6338934 
Fix account balance check (#266)
Kourin1996 pushed a commit that referenced this pull request Jul 30, 2025
@palango @Kourin1996
refactor: Create FeeCurrencyContext in NewEVMBlockContext
760050c 
Fix account balance check (#266)
Kourin1996 pushed a commit that referenced this pull request Jul 30, 2025
@palango @Kourin1996
refactor: Create FeeCurrencyContext in NewEVMBlockContext
8060b93 
Fix account balance check (#266)
Kourin1996 pushed a commit that referenced this pull request Jul 31, 2025
@gastonponti @Kourin1996
e2e(fee_currency): Fix account balance check (#266)
9b45cd7
Kourin1996 pushed a commit that referenced this pull request Jul 31, 2025
@gastonponti @Kourin1996
e2e(fee_currency): Fix account balance check (#266)
e9c8cfd
Kourin1996 pushed a commit that referenced this pull request Jul 31, 2025
@gastonponti @Kourin1996
e2e(fee_currency): Fix account balance check (#266)
c951f65
Kourin1996 pushed a commit that referenced this pull request Aug 1, 2025
@gastonponti @Kourin1996
e2e(fee_currency): Fix account balance check (#266)
0679b4d
Kourin1996 pushed a commit that referenced this pull request Aug 3, 2025
@gastonponti @Kourin1996
e2e(fee_currency): Fix account balance check (#266)
19d7acf
Kourin1996 pushed a commit that referenced this pull request Aug 4, 2025
@karlb @Kourin1996
e2e: Test fee currencies with failing debit/credit (#85)
5786433 
This should normally not happen, but we have to make sure that such a
rare case won't crash geth nodes are cause stuck transactions that will
get re-executed on every block.

e2e(fee_currency): Refactor fee currency e2e tests (#212, #258)

Refactors debug fee currency deployment ensuring fee currency cleanup. The
geth-devmode predeployed "oracle3" is reused throughout the e2e tests
for all dynamically deployed fee-currencies. However the tested
fee-currencies are never removed from the FeeCurrencyDirectory.

This causes the node to try to query exchange-rates for the leftover
fee-currencies. This fails, because the oracle associated with the old
fee-currency has a different token address assigned and thus causes a
revert. This issue is not critical and only causes emission of a log
message and some unneccessary evm calls,
but it is better practice to clean up the fee-currency from the
directory anyways.

Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com>

[squash]: e2e(ci): update foundry version to v1.1.0 (#380)

e2e(fee_currency): Update error message assertion (#363)

e2e(fee_currency): Fix account balance check (#266)

e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261)

Co-authored-by: Karl Bartel <karl.bartel@clabs.co>

e2e(runner|fee_currency): Fix failing e2e test (#371)

* Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees

* Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e

* Fix log assertion in e2e

* Add several e2e tests for admin blocking API

* Remove broadcast
Kourin1996 pushed a commit that referenced this pull request Aug 4, 2025
@karlb @Kourin1996
e2e: Test fee currencies with failing debit/credit (#85)
4262854 
This should normally not happen, but we have to make sure that such a
rare case won't crash geth nodes are cause stuck transactions that will
get re-executed on every block.

e2e(fee_currency): Refactor fee currency e2e tests (#212, #258)

Refactors debug fee currency deployment ensuring fee currency cleanup. The
geth-devmode predeployed "oracle3" is reused throughout the e2e tests
for all dynamically deployed fee-currencies. However the tested
fee-currencies are never removed from the FeeCurrencyDirectory.

This causes the node to try to query exchange-rates for the leftover
fee-currencies. This fails, because the oracle associated with the old
fee-currency has a different token address assigned and thus causes a
revert. This issue is not critical and only causes emission of a log
message and some unneccessary evm calls,
but it is better practice to clean up the fee-currency from the
directory anyways.

Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com>

[squash]: e2e(ci): update foundry version to v1.1.0 (#380)

e2e(fee_currency): Update error message assertion (#363)

e2e(fee_currency): Fix account balance check (#266)

e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261)

Co-authored-by: Karl Bartel <karl.bartel@clabs.co>

e2e(runner|fee_currency): Fix failing e2e test (#371)

* Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees

* Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e

* Fix log assertion in e2e

* Add several e2e tests for admin blocking API

* Remove broadcast
Kourin1996 pushed a commit that referenced this pull request Aug 4, 2025
@karlb @Kourin1996
e2e: Test fee currencies with failing debit/credit (#85)
7941be2 
This should normally not happen, but we have to make sure that such a
rare case won't crash geth nodes are cause stuck transactions that will
get re-executed on every block.

e2e(fee_currency): Refactor fee currency e2e tests (#212, #258)

Refactors debug fee currency deployment ensuring fee currency cleanup. The
geth-devmode predeployed "oracle3" is reused throughout the e2e tests
for all dynamically deployed fee-currencies. However the tested
fee-currencies are never removed from the FeeCurrencyDirectory.

This causes the node to try to query exchange-rates for the leftover
fee-currencies. This fails, because the oracle associated with the old
fee-currency has a different token address assigned and thus causes a
revert. This issue is not critical and only causes emission of a log
message and some unneccessary evm calls,
but it is better practice to clean up the fee-currency from the
directory anyways.

Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com>

[squash]: e2e(ci): update foundry version to v1.1.0 (#380)

e2e(fee_currency): Update error message assertion (#363)

e2e(fee_currency): Fix account balance check (#266)

e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261)

Co-authored-by: Karl Bartel <karl.bartel@clabs.co>

e2e(runner|fee_currency): Fix failing e2e test (#371)

* Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees

* Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e

* Fix log assertion in e2e

* Add several e2e tests for admin blocking API

* Remove broadcast
Kourin1996 pushed a commit that referenced this pull request Aug 4, 2025
@karlb @Kourin1996
e2e: Test fee currencies with failing debit/credit (#85)
00cb353 
This should normally not happen, but we have to make sure that such a
rare case won't crash geth nodes are cause stuck transactions that will
get re-executed on every block.

e2e(fee_currency): Refactor fee currency e2e tests (#212, #258)

Refactors debug fee currency deployment ensuring fee currency cleanup. The
geth-devmode predeployed "oracle3" is reused throughout the e2e tests
for all dynamically deployed fee-currencies. However the tested
fee-currencies are never removed from the FeeCurrencyDirectory.

This causes the node to try to query exchange-rates for the leftover
fee-currencies. This fails, because the oracle associated with the old
fee-currency has a different token address assigned and thus causes a
revert. This issue is not critical and only causes emission of a log
message and some unneccessary evm calls,
but it is better practice to clean up the fee-currency from the
directory anyways.

Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com>

[squash]: e2e(ci): update foundry version to v1.1.0 (#380)

e2e(fee_currency): Update error message assertion (#363)

e2e(fee_currency): Fix account balance check (#266)

e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261)

Co-authored-by: Karl Bartel <karl.bartel@clabs.co>

e2e(runner|fee_currency): Fix failing e2e test (#371)

* Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees

* Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e

* Fix log assertion in e2e

* Add several e2e tests for admin blocking API

* Remove broadcast
Kourin1996 pushed a commit that referenced this pull request Aug 4, 2025
@karlb @Kourin1996
e2e: Test fee currencies with failing debit/credit (#85)
359819b 
This should normally not happen, but we have to make sure that such a
rare case won't crash geth nodes are cause stuck transactions that will
get re-executed on every block.

e2e(fee_currency): Refactor fee currency e2e tests (#212, #258)

Refactors debug fee currency deployment ensuring fee currency cleanup. The
geth-devmode predeployed "oracle3" is reused throughout the e2e tests
for all dynamically deployed fee-currencies. However the tested
fee-currencies are never removed from the FeeCurrencyDirectory.

This causes the node to try to query exchange-rates for the leftover
fee-currencies. This fails, because the oracle associated with the old
fee-currency has a different token address assigned and thus causes a
revert. This issue is not critical and only causes emission of a log
message and some unneccessary evm calls,
but it is better practice to clean up the fee-currency from the
directory anyways.

Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com>

[squash]: e2e(ci): update foundry version to v1.1.0 (#380)

e2e(fee_currency): Update error message assertion (#363)

e2e(fee_currency): Fix account balance check (#266)

e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261)

Co-authored-by: Karl Bartel <karl.bartel@clabs.co>

e2e(runner|fee_currency): Fix failing e2e test (#371)

* Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees

* Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e

* Fix log assertion in e2e

* Add several e2e tests for admin blocking API

* Remove broadcast
Kourin1996 pushed a commit that referenced this pull request Aug 5, 2025
@karlb @Kourin1996
e2e: Test fee currencies with failing debit/credit (#85)
06a6c5f 
This should normally not happen, but we have to make sure that such a
rare case won't crash geth nodes are cause stuck transactions that will
get re-executed on every block.

e2e(fee_currency): Refactor fee currency e2e tests (#212, #258)

Refactors debug fee currency deployment ensuring fee currency cleanup. The
geth-devmode predeployed "oracle3" is reused throughout the e2e tests
for all dynamically deployed fee-currencies. However the tested
fee-currencies are never removed from the FeeCurrencyDirectory.

This causes the node to try to query exchange-rates for the leftover
fee-currencies. This fails, because the oracle associated with the old
fee-currency has a different token address assigned and thus causes a
revert. This issue is not critical and only causes emission of a log
message and some unneccessary evm calls,
but it is better practice to clean up the fee-currency from the
directory anyways.

Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com>

[squash]: e2e(ci): update foundry version to v1.1.0 (#380)

e2e(fee_currency): Update error message assertion (#363)

e2e(fee_currency): Fix account balance check (#266)

e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261)

Co-authored-by: Karl Bartel <karl.bartel@clabs.co>

e2e(runner|fee_currency): Fix failing e2e test (#371)

* Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees

* Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e

* Fix log assertion in e2e

* Add several e2e tests for admin blocking API

* Remove broadcast
Kourin1996 pushed a commit that referenced this pull request Aug 5, 2025
@karlb @Kourin1996
e2e: Test fee currencies with failing debit/credit (#85)
eb79931 
This should normally not happen, but we have to make sure that such a
rare case won't crash geth nodes are cause stuck transactions that will
get re-executed on every block.

e2e(fee_currency): Refactor fee currency e2e tests (#212, #258)

Refactors debug fee currency deployment ensuring fee currency cleanup. The
geth-devmode predeployed "oracle3" is reused throughout the e2e tests
for all dynamically deployed fee-currencies. However the tested
fee-currencies are never removed from the FeeCurrencyDirectory.

This causes the node to try to query exchange-rates for the leftover
fee-currencies. This fails, because the oracle associated with the old
fee-currency has a different token address assigned and thus causes a
revert. This issue is not critical and only causes emission of a log
message and some unneccessary evm calls,
but it is better practice to clean up the fee-currency from the
directory anyways.

Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com>

[squash]: e2e(ci): update foundry version to v1.1.0 (#380)

e2e(fee_currency): Update error message assertion (#363)

e2e(fee_currency): Fix account balance check (#266)

e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261)

Co-authored-by: Karl Bartel <karl.bartel@clabs.co>

e2e(runner|fee_currency): Fix failing e2e test (#371)

* Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees

* Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e

* Fix log assertion in e2e

* Add several e2e tests for admin blocking API

* Remove broadcast
Kourin1996 pushed a commit that referenced this pull request Aug 5, 2025
@karlb @Kourin1996
e2e: Test fee currencies with failing debit/credit (#85)
baf4e0f 
This should normally not happen, but we have to make sure that such a
rare case won't crash geth nodes are cause stuck transactions that will
get re-executed on every block.

e2e(fee_currency): Refactor fee currency e2e tests (#212, #258)

Refactors debug fee currency deployment ensuring fee currency cleanup. The
geth-devmode predeployed "oracle3" is reused throughout the e2e tests
for all dynamically deployed fee-currencies. However the tested
fee-currencies are never removed from the FeeCurrencyDirectory.

This causes the node to try to query exchange-rates for the leftover
fee-currencies. This fails, because the oracle associated with the old
fee-currency has a different token address assigned and thus causes a
revert. This issue is not critical and only causes emission of a log
message and some unneccessary evm calls,
but it is better practice to clean up the fee-currency from the
directory anyways.

Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com>

[squash]: e2e(ci): update foundry version to v1.1.0 (#380)

e2e(fee_currency): Update error message assertion (#363)

e2e(fee_currency): Fix account balance check (#266)

e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261)

Co-authored-by: Karl Bartel <karl.bartel@clabs.co>

e2e(runner|fee_currency): Fix failing e2e test (#371)

* Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees

* Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e

* Fix log assertion in e2e

* Add several e2e tests for admin blocking API

* Remove broadcast
Kourin1996 pushed a commit that referenced this pull request Aug 6, 2025
@karlb @Kourin1996
e2e: Test fee currencies with failing debit/credit (#85)
83eecf1 
This should normally not happen, but we have to make sure that such a
rare case won't crash geth nodes are cause stuck transactions that will
get re-executed on every block.

e2e(fee_currency): Refactor fee currency e2e tests (#212, #258)

Refactors debug fee currency deployment ensuring fee currency cleanup. The
geth-devmode predeployed "oracle3" is reused throughout the e2e tests
for all dynamically deployed fee-currencies. However the tested
fee-currencies are never removed from the FeeCurrencyDirectory.

This causes the node to try to query exchange-rates for the leftover
fee-currencies. This fails, because the oracle associated with the old
fee-currency has a different token address assigned and thus causes a
revert. This issue is not critical and only causes emission of a log
message and some unneccessary evm calls,
but it is better practice to clean up the fee-currency from the
directory anyways.

Co-authored-by: Maximilian Langenfeld <15726643+ezdac@users.noreply.github.com>

[squash]: e2e(ci): update foundry version to v1.1.0 (#380)

e2e(fee_currency): Update error message assertion (#363)

e2e(fee_currency): Fix account balance check (#266)

e2e(fee_currency): Import viem_setup.mjs instead of setup viem in send_tx.mjs (#261)

Co-authored-by: Karl Bartel <karl.bartel@clabs.co>

e2e(runner|fee_currency): Fix failing e2e test (#371)

* Add Random in BlockContext to enable Merge and Shanghai fork in TryDebitFees

* Add --broadcast option in deploy_fee_currency to ensure fee currency is deployed in e2e

* Fix log assertion in e2e

* Add several e2e tests for admin blocking API

* Remove broadcast
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@piersy piersy piersy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gastonponti @piersy