Conversation
Codecov Report
@@ Coverage Diff @@
## main #2728 +/- ##
==========================================
- Coverage 51.51% 51.32% -0.19%
==========================================
Files 162 163 +1
Lines 10755 10784 +29
==========================================
- Hits 5540 5535 -5
- Misses 4734 4764 +30
- Partials 481 485 +4
|
Member
|
Why is it breaking again? |
Contributor
Author
ramin
reviewed
Sep 19, 2023
Contributor
ramin
left a comment
There was a problem hiding this comment.
Do we have to do follow on work to fix rpc after this?
Contributor
Author
|
@ramin Yes! We need to update the openrpc json after this, but its not in main yet |
ramin
approved these changes
Sep 21, 2023
Wondertan
approved these changes
Sep 21, 2023
walldiss
approved these changes
Sep 21, 2023
This was referenced Sep 21, 2023
github-merge-queue bot
pushed a commit
to celestiaorg/celestia-openrpc
that referenced
this pull request
Oct 17, 2023
Upgrades to match node [v0.11.0-rc14 - Cache Fixes](https://github.com/celestiaorg/celestia-node/releases/tag/v0.11.0-rc14) Related: celestiaorg/celestia-node#2728 Co-authored-by: nashqueue <99758629+nashqueue@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: celestiaorg/nmt#233